Replace InMemoryInstance with InMemoryAccumulo#3345
Open
SethSmucker wants to merge 19 commits into
Open
Conversation
- Remove extends ClientContext from InMemoryAccumuloClient - Remove extends Connector from InMemoryConnector - Remove implements Instance from InMemoryInstance - Delete InMemoryClientInfo.java (used non-public Credentials/ClientInfoImpl) - Clean up BulkInputFormat TabletLocator usage - Update PushdownScheduler to remove ClientContext usage Part of #2443
54 tasks
Collaborator
Author
Stacked PR NoticeThis PR is stacked on #3253 and shares files with it.
Shared files:
IMPORTANT: Do NOT merge this until #3253 is merged. After #3253 merges, update this branch: git checkout task/replace-inmemoryinstance
git merge origin/integration
git push |
This was referenced Jan 7, 2026
Apply formatter, sortpom, and impsort fixes to pass CI check.
The getClientContext method used non-public ClientContext API and was only called from PushdownScheduler. Since PushdownScheduler now uses the public tableOperations().tableIdMap() API instead, this utility method is no longer needed. Supersedes PR #3340.
Re-apply #3345 changes on top of current #3253 base (0d73343). Cherry-picked ce539af and resolved 6 conflicts by taking the current base's test structure (AbstractQueryTest framework) with InMemoryInstance swapped to InMemoryAccumulo. BulkInputFormat: only swapped the InMemoryInstance constructor call. getTabletLocator/TabletLocator code left as-is (will be replaced when #3449 merges). Version alignment: root pom in-memory-accumulo version bumped from 4.0.5-SNAPSHOT to 4.0.6-SNAPSHOT to match module pom. Fixes #2597 Part of #2443
SethSmucker
force-pushed
the
task/replace-inmemoryinstance
branch
from
ce539af to
50535b9
Compare
16 test files had InMemoryAccumulo usage without the import (cherry-pick swapped class names but import replacement didn't apply to these files). NumShardsTest: replaced i.getZooKeepers() with "localhost" literal since InMemoryAccumulo doesn't have that method (InMemoryInstance returned "localhost" hardcoded).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getInstance(String)static method to InMemoryAccumulo for named instance sharingclearInstances()method for test cleanupInMemoryAccumuloClient(String, InMemoryInstance)constructorDependencies
This PR depends on #3253 being merged first. It builds on top of those changes.
Fixes #2597
Part of #2443