Update NationsGloryJava.yml #1
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70b6c3be72
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # ChestShop | ||
| # =========================== | ||
| chestshop_transaction: | ||
| pattern: "{timestamp} [ChestShop] {player} {action} {qty} {item} for {price} {direction} {target} at [world] {x}, {y}, {z}" |
There was a problem hiding this comment.
This pattern hard-codes at [world], so it only matches transactions that occur in a world literally named “world”. ChestShop logs include the world name in brackets (e.g., at [world_nether] …), and those entries will not parse with this pattern, causing missed transactions whenever servers use non-default world names. Consider capturing the world token (e.g., [{world}]) so multi-world logs still match.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR adds 30 new log patterns to the NationsGloryJava.yml file for parsing additional server logs from the NationsGlory Minecraft server plugin. The patterns are based on a Python script from akael V.2023 and cover various game mechanics including auctions, shops, wars, economy, and player sessions.
Changes:
- Added patterns for auction system events (new, bid, end, refund, cancelled)
- Added patterns for shop transactions (ChestShop, AdminShop, Catalog)
- Added patterns for war-related events (add, start, surrender, status changes, warzone)
- Added patterns for economy and country management (purchases, founding, leadership changes, colonies)
- Added patterns for miscellaneous events (powerboosts, meteors, access control, duels, missiles, player sessions)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| pattern: "{timestamp} [Auction] New Player auction {details}" | ||
|
|
||
| auction_bid: | ||
| pattern: "{timestamp} [Auction] New Player bid {details}" | ||
|
|
||
| auction_end: | ||
| pattern: "{timestamp} [Auction] End of auction {details}" | ||
|
|
||
| auction_refund: | ||
| pattern: "{timestamp} [Auction] Refund {details}" | ||
|
|
||
| auction_cancelled: | ||
| pattern: "{timestamp} [Auction] CANCELLED {details}" |
There was a problem hiding this comment.
Consider providing more specific variable names instead of the generic {details} placeholder. Other patterns in the file use explicit variables (e.g., {player}, {country}, {amount}) which makes log parsing more structured and useful. For example, this could be parsed into specific fields like {auction_id}, {item}, {price}, {player}, etc.
|
|
||
| # =========================== | ||
| # ChestShop | ||
| # =========================== |
There was a problem hiding this comment.
The pattern variable {direction} is ambiguous. Consider using a more descriptive name like {transaction_type} or clarifying in documentation what values this field represents (e.g., "to"/"from", "bought"/"sold", etc.).
| # =========================== | |
| # =========================== | |
| # {direction}: direction of the transaction, e.g. "to"/"from" the target player or shop. |
| adminshop_transaction: | ||
| pattern: "{timestamp} {player} {details} from Adminshop" | ||
|
|
||
| adminshop_transaction_lower: | ||
| pattern: "{timestamp} {player} {details} from adminshop" |
There was a problem hiding this comment.
Inconsistent capitalization between patterns. Line 209 uses "Adminshop" while line 212 uses "adminshop" in the pattern text. If these represent the same log source, they should use consistent capitalization. If they represent different log formats from the server, consider using more distinct pattern names to clarify the difference.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 participant
Type de modification
Coche au moins une case
Description
Explique clairement :
Ajout des logs suivantes :
Ajouts basé sur le script python d'akael V.2023 , des modifications de logs ont du avoir lieu je vous laisses me le faire remonter
Impact potentiel
Justification (si nécessaire) : /
Checklist
snake_caseInformations complémentaires
Toute information utile à la revue : Ajouts basé sur le script python d'akael V.2023 , des modifications de logs ont du avoir lieu je vous laisses me le faire remonter