refactor(receipts): remove dead createClaimSupportReceipt helper - #13
Closed
Munawarx wants to merge 1 commit into
Closed
refactor(receipts): remove dead createClaimSupportReceipt helper#13Munawarx wants to merge 1 commit into
Munawarx wants to merge 1 commit into
Conversation
The helper was superseded by the evidence-contact -> claim-support link in finalization.js and documented as dead in the new path (src/receipts.js:86), yet was still exported and unit-tested. Remove the function, its index.js export, and its test cases (migrated to the active appendReceipt/validateReceipt surface). Reduces surface area and matches the project's 'claims carry receipts' clarity standard. Router + receipt + package suites: 44/44 green (no regressions). Quick fix per CONTRIBUTING (no core-surface/security-boundary change). Co-Authored-By: Hermes Agent <noreply@hermes.ai>
Contributor
Author
|
Tracking our current contribution set for Leadline (Munawarx). All are independent, each on its own branch:
Each PR is self-contained and ready to review independently. Happy to split, adjust, or rebase any of them. Co-Authored-By: Hermes Agent noreply@hermes.ai |
This was referenced Jul 26, 2026
Owner
|
Closing after review: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the dead
createClaimSupportReceipthelper fromsrc/receipts.js. It was superseded by the evidence-contact → claim-support link infinalization.jsand was already documented as dead in the new path (src/receipts.js:86), yet it remained exported fromreceipts.js/index.jsand covered by 5 unit tests — a clarity/footgun violation of the project's own "claims carry receipts" standard.Changes
src/receipts.js.src/index.js(require+module.exports).module.exportsinsrc/receipts.js.test/receipts.test.jswith tests that exercise the active surface (appendReceiptownership-restricted JSONL write, invalid-receipt rejection,validateReceiptidentity-tamper detection).test/package.test.js.Verification
node --test test/receipts.test.js test/package.test.js test/matcher.test.js test/planner.test.js test/decompose.test.js test/satisfaction.test.js test/runtime-current-state.test.js→ pass 44, fail 0.Ground-rule compliance
Files
src/receipts.jssrc/index.jstest/receipts.test.jstest/package.test.jsCo-Authored-By: Hermes Agent noreply@hermes.ai