Skip to content

Remove wrong PlaceName property from HeadingSign#945

Merged
skinkie merged 2 commits intoNeTEx-CEN:nextfrom
OPENER-next:fix-heading-sign
Aug 26, 2025
Merged

Remove wrong PlaceName property from HeadingSign#945
skinkie merged 2 commits intoNeTEx-CEN:nextfrom
OPENER-next:fix-heading-sign

Conversation

@Robbendebiene
Copy link
Contributor

While working at #944 I noticed that in order to add any HeadingSign specific property (like LineName or TransportSubmode) I had to define a PlaceName first. This is probably a copy paste error from PlaceSign. At least to me it doesn't make sense why there should be a mandatory PlaceName property that must exist in order to define any properties from the HeadingSignGroup.

It is probably to late but since this would be a braking change perhaps it could be included in 2.0. Otherwise I could also deprecate the property and set it to minOccurs="0". Let me know what you think @Aurige @skinkie

@skinkie
Copy link
Contributor

skinkie commented Jul 28, 2025

@nick-knowles has added it.

@skinkie skinkie requested review from Aurige and nick-knowles July 28, 2025 09:19
@Aurige
Copy link
Contributor

Aurige commented Aug 4, 2025

To me it should not be mandatory, but I would still keep (that's often that a HEADSIGN is the name of the destination place).

@Robbendebiene
Copy link
Contributor Author

but I would still keep (that's often that a HEADSIGN is the name of the destination place).

@Aurige Isn't the name of the destination described via the DirectionName (from HeadingSignGroup) or is there a difference?

@Aurige
Copy link
Contributor

Aurige commented Aug 4, 2025

Direction is more something like south/west/inbound/outbound/clockwise/left/right, etc.
Destination is the end station
Place would be a city, a POI, etc.

But I agree that additional comments would help

@Robbendebiene
Copy link
Contributor Author

@Aurige Okay thanks for the clarification. I re-introduced the PlaceName property, but made it optional. I also moved it to the HeadingSignGroup and slightly altered its documentation.

@Aurige
Copy link
Contributor

Aurige commented Aug 26, 2025

26/08 : need Check with example

Copy link
Contributor

@skinkie skinkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it validates, continue.

@skinkie
Copy link
Contributor

skinkie commented Aug 26, 2025

(and it is currently not checked within github!)

@skinkie
Copy link
Contributor

skinkie commented Aug 26, 2025

@Aurige I checked it. Examples validate, may be approved (and merged)

@skinkie skinkie merged commit c21e71f into NeTEx-CEN:next Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants