Remove wrong PlaceName property from HeadingSign#945
Conversation
|
@nick-knowles has added it. |
|
To me it should not be mandatory, but I would still keep (that's often that a HEADSIGN is the name of the destination place). |
@Aurige Isn't the name of the destination described via the |
|
Direction is more something like south/west/inbound/outbound/clockwise/left/right, etc. But I agree that additional comments would help |
|
@Aurige Okay thanks for the clarification. I re-introduced the |
|
26/08 : need Check with example |
skinkie
left a comment
There was a problem hiding this comment.
If it validates, continue.
|
(and it is currently not checked within github!) |
|
@Aurige I checked it. Examples validate, may be approved (and merged) |
While working at #944 I noticed that in order to add any
HeadingSignspecific property (likeLineNameorTransportSubmode) I had to define aPlaceNamefirst. This is probably a copy paste error fromPlaceSign. At least to me it doesn't make sense why there should be a mandatoryPlaceNameproperty that must exist in order to define any properties from theHeadingSignGroup.It is probably to late but since this would be a braking change perhaps it could be included in 2.0. Otherwise I could also deprecate the property and set it to
minOccurs="0". Let me know what you think @Aurige @skinkie