Add support for Ledger HW wallet

.github/workflows/ci_cd.yml

@@ -18,16 +18,16 @@ env:
 jobs:
 
   linux_daemon_cmake:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-22.04
     steps:
     - uses: actions/checkout@v1
     - name: ccache
       uses: actions/cache@v2
       with:
         path: .ccache
-        key: ${{ runner.OS }}-${{ env.CACHE_VER }}-18.04-linux_daemon_cmake-${{ github.sha }}-${{ github.run_id }}
+        key: ${{ runner.OS }}-${{ env.CACHE_VER }}-22.04-linux_daemon_cmake-${{ github.sha }}-${{ github.run_id }}
         restore-keys: |
-          ${{ runner.OS }}-${{ env.CACHE_VER }}-18.04-linux_daemon_cmake-
+          ${{ runner.OS }}-${{ env.CACHE_VER }}-22.04-linux_daemon_cmake-
     - name: Set target_v env var
       run: |
         echo "target_v=linux_daemon_cmake" >> $GITHUB_ENV
@@ -42,16 +42,16 @@ jobs:
         path: /tmp/bitcoin*
 
   linux_daemon:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-22.04
     steps:
     - uses: actions/checkout@v1
     - name: ccache
       uses: actions/cache@v2
       with:
         path: .ccache
-        key: ${{ runner.OS }}-${{ env.CACHE_VER }}-18.04-linux_daemon-${{ github.sha }}-${{ github.run_id }}
+        key: ${{ runner.OS }}-${{ env.CACHE_VER }}-22.04-linux_daemon-${{ github.sha }}-${{ github.run_id }}
         restore-keys: |
-          ${{ runner.OS }}-${{ env.CACHE_VER }}-18.04-linux_daemon-
+          ${{ runner.OS }}-${{ env.CACHE_VER }}-22.04-linux_daemon-
     - name: Set target_v env var
       run: |
         echo "target_v=linux_daemon" >> $GITHUB_ENV
@@ -67,19 +67,24 @@ jobs:
         files: ${{ env.SOURCE_PATH }}
         repo-token: ${{ secrets.GHAT2 }}
         release-tag: ${{ env.RELEASE_TAG }}
+    - name: Upload artifacts
+      uses: actions/upload-artifact@v3
+      with:
+        name: nebliod-linux.tar.gz
+        path: ${{ github.workspace }}/deploy/*nebliod*.tar.gz
 
 
   linux_wallet:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-22.04
     steps:
     - uses: actions/checkout@v1
     - name: ccache
       uses: actions/cache@v2
       with:
         path: .ccache
-        key: ${{ runner.OS }}-${{ env.CACHE_VER }}-18.04-linux_wallet-${{ github.sha }}-${{ github.run_id }}
+        key: ${{ runner.OS }}-${{ env.CACHE_VER }}-22.04-linux_wallet-${{ github.sha }}-${{ github.run_id }}
         restore-keys: |
-          ${{ runner.OS }}-${{ env.CACHE_VER }}-18.04-linux_wallet-
+          ${{ runner.OS }}-${{ env.CACHE_VER }}-22.04-linux_wallet-
     - name: Set target_v env var
       run: |
         echo "target_v=linux_wallet" >> $GITHUB_ENV
@@ -94,20 +99,25 @@ jobs:
         files: ${{ env.SOURCE_PATH }}
         repo-token: ${{ secrets.GHAT2 }}
         release-tag: ${{ env.RELEASE_TAG }}
+    - name: Upload artifacts
+      uses: actions/upload-artifact@v3
+      with:
+        name: neblio-qt-linux.tar.gz
+        path: ${{ github.workspace }}/deploy/*neblio-Qt*.tar.gz
 
 
   linux_wallet_test:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-22.04
     steps:
     - uses: actions/checkout@v1
     - name: ccache
       uses: actions/cache@v2
       with:
         path: .ccache
-        key: ${{ runner.OS }}-${{ env.CACHE_VER }}-18.04-linux_wallet_test-${{ github.sha }}-${{ github.run_id }}
+        key: ${{ runner.OS }}-${{ env.CACHE_VER }}-22.04-linux_wallet_test-${{ github.sha }}-${{ github.run_id }}
         restore-keys: |
-          ${{ runner.OS }}-${{ env.CACHE_VER }}-18.04-linux_wallet_test-
-          ${{ runner.OS }}-${{ env.CACHE_VER }}-18.04-linux_wallet-
+          ${{ runner.OS }}-${{ env.CACHE_VER }}-22.04-linux_wallet_test-
+          ${{ runner.OS }}-${{ env.CACHE_VER }}-22.04-linux_wallet-
     - name: Set target_v env var
       run: |
         echo "target_v=linux_wallet_test" >> $GITHUB_ENV
@@ -117,16 +127,16 @@ jobs:
 
 
   windows_x86:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-22.04
     steps:
     - uses: actions/checkout@v1
     - name: ccache
       uses: actions/cache@v2
       with:
         path: .ccache
-        key: ${{ runner.OS }}-${{ env.CACHE_VER }}-18.04-windows_x86-${{ github.sha }}-${{ github.run_id }}
+        key: ${{ runner.OS }}-${{ env.CACHE_VER }}-22.04-windows_x86-${{ github.sha }}-${{ github.run_id }}
         restore-keys: |
-          ${{ runner.OS }}-${{ env.CACHE_VER }}-18.04-windows_x86-
+          ${{ runner.OS }}-${{ env.CACHE_VER }}-22.04-windows_x86-
     - name: Build neblio-Qt for Windows x86
       run: |
         python -u ci_scripts/test_win_x86-gui_wallet.py
@@ -138,6 +148,11 @@ jobs:
         files: ${{ env.SOURCE_PATH }}
         repo-token: ${{ secrets.GHAT2 }}
         release-tag: ${{ env.RELEASE_TAG }}
+    - name: Upload artifacts
+      uses: actions/upload-artifact@v3
+      with:
+        name: neblio-qt-windows.zip
+        path: ${{ github.workspace }}/deploy/*neblio-Qt*.zip
 
 
   osx:
@@ -165,6 +180,11 @@ jobs:
         files: ${{ env.SOURCE_PATH }}
         repo-token: ${{ secrets.GHAT2 }}
         release-tag: ${{ env.RELEASE_TAG }}
+    - name: Upload artifacts
+      uses: actions/upload-artifact@v3
+      with:
+        name: neblio-qt-mac.zip
+        path: ${{ github.workspace }}/deploy/*neblio-Qt*.zip
 
 
   osx_test:
@@ -240,16 +260,16 @@ jobs:
   rpi_wallet:
     # Only Build RPi on Daily Scheduled Runs and releases as it takes a long time
     if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || startsWith(github.ref, 'refs/tags/v')
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-22.04
     steps:
     - uses: actions/checkout@v1
     - name: ccache
       uses: actions/cache@v2
       with:
         path: .ccache
-        key: ${{ runner.OS }}-${{ env.CACHE_VER }}-18.04-rpi_wallet-${{ github.sha }}-${{ github.run_id }}
+        key: ${{ runner.OS }}-${{ env.CACHE_VER }}-22.04-rpi_wallet-${{ github.sha }}-${{ github.run_id }}
         restore-keys: |
-          ${{ runner.OS }}-${{ env.CACHE_VER }}-18.04-rpi_wallet-
+          ${{ runner.OS }}-${{ env.CACHE_VER }}-22.04-rpi_wallet-
     - name: Set target_v env var
       run: |
         echo "target_v=rpi_wallet" >> $GITHUB_ENV
@@ -269,17 +289,17 @@ jobs:
   rpi_wallet_test:
     # Only Build RPi on Daily Scheduled Runs and releases as it takes a long time
     if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || startsWith(github.ref, 'refs/tags/v')
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-22.04
     steps:
     - uses: actions/checkout@v1
     - name: ccache
       uses: actions/cache@v2
       with:
         path: .ccache
-        key: ${{ runner.OS }}-${{ env.CACHE_VER }}-18.04-rpi_wallet_test-${{ github.sha }}-${{ github.run_id }}
+        key: ${{ runner.OS }}-${{ env.CACHE_VER }}-22.04-rpi_wallet_test-${{ github.sha }}-${{ github.run_id }}
         restore-keys: |
-          ${{ runner.OS }}-${{ env.CACHE_VER }}-18.04-rpi_wallet_test-
-          ${{ runner.OS }}-${{ env.CACHE_VER }}-18.04-rpi_wallet-
+          ${{ runner.OS }}-${{ env.CACHE_VER }}-22.04-rpi_wallet_test-
+          ${{ runner.OS }}-${{ env.CACHE_VER }}-22.04-rpi_wallet-
     - name: Set target_v env var
       run: |
         echo "target_v=rpi_wallet_test" >> $GITHUB_ENV
@@ -297,16 +317,16 @@ jobs:
   rpi_daemon:
     # Only Build RPi on Daily Scheduled Runs and releases as it takes a long time
     if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || startsWith(github.ref, 'refs/tags/v')
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-22.04
     steps:
     - uses: actions/checkout@v1
     - name: ccache
       uses: actions/cache@v2
       with:
         path: .ccache
-        key: ${{ runner.OS }}-${{ env.CACHE_VER }}-18.04-rpi_daemon-${{ github.sha }}-${{ github.run_id }}
+        key: ${{ runner.OS }}-${{ env.CACHE_VER }}-22.04-rpi_daemon-${{ github.sha }}-${{ github.run_id }}
         restore-keys: |
-          ${{ runner.OS }}-${{ env.CACHE_VER }}-18.04-rpi_daemon-
+          ${{ runner.OS }}-${{ env.CACHE_VER }}-22.04-rpi_daemon-
     - name: Set target_v env var
       run: |
         echo "target_v=rpi_daemon" >> $GITHUB_ENV

.gitignore

@@ -17,6 +17,8 @@ wallet/leveldb/build_config.mk
 debug
 .neblio
 release/
+.qtc_clangd
+.vscode
 
 #compilation and Qt preprocessor part
 *.qm
@@ -71,3 +73,9 @@ wallet/test/data/txs_ntp1tests_ntp1_txs_testnet.json
 wallet/test/data/txs_ntp1tests_raw_neblio_txs_testnet.json
 wallet/test/data/ntp1txids_to_test.txt
 wallet/test/data/ntp1txids_to_test_testnet.txt
+
+boost*/
+openssl*/
+boost_build
+openssl_build
+*.tar.gz

CMakeLists.txt

@@ -124,6 +124,7 @@ find_package(PkgConfig        REQUIRED)
 find_package(Boost 1.65       COMPONENTS system random filesystem thread regex program_options iostreams atomic REQUIRED)
 find_package(Threads          REQUIRED)
 find_package(sodium           REQUIRED)
+find_package(HIDAPI           REQUIRED)
 
 set(ATOMIC32_TEST_CODE "
     #include <atomic>
@@ -595,6 +596,8 @@ add_library(gui_lib STATIC
     wallet/qt/votesdatamodel.cpp
     wallet/qt/votesdataview.cpp
     wallet/qt/votestablecelldelegate.cpp
+    wallet/qt/ledger_ui/ledgermessagebox.cpp
+    wallet/qt/ledger_ui/ledgeruiutils.cpp
     ${QRCODE_SOURCES}
     )
 
@@ -625,6 +628,8 @@ add_library(ui_lib STATIC
     wallet/qt/ui_sendcoinsentry.h
     wallet/qt/ui_signverifymessagedialog.h
     wallet/qt/ui_transactiondescdialog.h
+    wallet/qt/ledger_ui/ledgermessagebox.h
+    wallet/qt/ledger_ui/ledgeruiutils.h
     )
 
 target_link_libraries(ui_lib
@@ -740,6 +745,15 @@ add_library(core_lib STATIC
     wallet/blockmetadata.cpp
     wallet/blockindexlrucache.cpp
     wallet/proposal.cpp
+    wallet/ledger/bytes.h
+    wallet/ledger/bip32.cpp
+    wallet/ledger/error.cpp
+    wallet/ledger/hid.cpp
+    wallet/ledger/ledger.cpp
+    wallet/ledger/transport.cpp
+    wallet/ledger/tx.cpp
+    wallet/ledger/utils.cpp
+    wallet/ledgerBridge.cpp
     )
 
 target_link_libraries(core_lib
@@ -750,6 +764,7 @@ target_link_libraries(core_lib
     db_lib
     utils_lib
     ${ATOMIC_LINKER_LIBS}
+    ${HIDAPI_LIBRARIES}
     )
 
 add_library(curltools_lib STATIC

README.md

@@ -16,10 +16,13 @@ Pull Requests Welcome
 ```
 sudo apt-get update && sudo apt-get install git python python-pip qt5-default qt5-qmake qtbase5-dev-tools \
 qttools5-dev-tools build-essential libssl-dev libdb++-dev libminiupnpc-dev \
-libqrencode-dev libcurl4-openssl-dev libldap2-dev libidn11-dev librtmp-dev libsodium-dev -y
+libqrencode-dev libcurl4-openssl-dev libldap2-dev libidn11-dev librtmp-dev libsodium-dev libudev-dev \
+libusb-1.0-0-dev libhidapi-dev -y
 pip install requests
 ```
 
+_Note: For Ubuntu 21.04 and newer the `qt5-default` package needs to be replaced with `qtbase5-dev`._
+
 ### Clone Repo
 ```
 git clone https://github.com/NeblioTeam/neblio
@@ -41,6 +44,8 @@ export QRENCODE_INCLUDE_PATH=$PWD/qrencode_build/include/
 export QRENCODE_LIB_PATH=$PWD/qrencode_build/lib/
 ```
 
+_Note: You might need to change `python` to `python3` on newer Ubuntu versions._
+
 ### Build nebliod
 ```
 cd wallet
@@ -66,13 +71,16 @@ sudo mv mxe /
 export PATH=/mxe/mxe/usr/bin:$PATH
 ```
 
+_Source for mxe can be found in [contrib/build_mxe](contrib/build_mxe)._
+
 ### Build neblio-Qt
 ```
 i686-w64-mingw32.static-qmake-qt5 "USE_UPNP=1" "USE_QRCODE=1" "RELEASE=1" neblio-wallet.pro
 make -B -w -j4
 ```
 
 ## macOS
+_Instructions don't work on Apple silicon._
 ### Install the following dependencies (homebrew)
 ```
 brew update
@@ -84,6 +92,7 @@ brew fetch --retry curl          && brew install curl --force
 brew fetch --retry openssl@1.1   && brew install openssl@1.1 --force
 brew fetch --retry qrencode      && brew install qrencode --force
 brew fetch --retry libsodium     && brew install libsodium --force
+brew fetch --retry hidapi        && brew install hidapi --force
 
 brew unlink qt            && brew link --force --overwrite qt
 brew unlink berkeley-db@4 && brew link --force --overwrite berkeley-db@4
@@ -94,6 +103,7 @@ brew unlink python        && brew link --force --overwrite python
 brew unlink openssl@1.1   && brew link --force --overwrite openssl@1.1
 brew unlink qrencode      && brew link --force --overwrite qrencode
 brew unlink libsodium     && brew link --force --overwrite libsodium
+brew unlink hidapi        && brew link --force --overwrite hidapi
 ```
 
 ### Build neblio-Qt
@@ -200,6 +210,7 @@ RPC commands are used to interact with a running instance of nebliod or neblio-Q
 
 ```
 abandontransaction <txid>
+addledgeraddress <account_index> <address_index> <label>
 addmultisigaddress <nrequired> <'["key","key"]'> [account]
 addnode "node" "add|remove|onetry"
 addredeemscript <redeemScript> [account]
@@ -236,6 +247,7 @@ getconnectioncount
 getdelegatedbalance
 getdifficulty
 getinfo
+getledgeraccount <neblioaddress or account>
 getmininginfo
 getnewaddress [account]
 getnewpubkey [account]
@@ -294,6 +306,7 @@ udtoneblioaddress <unstoppable domain address>
 uptime
 validateaddress <neblioaddress>
 validatepubkey <nebliopubkey>
+verifyledgeraddress <accountindex> <ischange> <addressindex> <expectedaddress>
 verifymessage <neblioaddress> <signature> <message>
 waitforblockheight (timeout)
 ```

build_scripts/CompileBoost-Linux.py

@@ -86,14 +86,9 @@ def download_boost():
 
 call("tar -xf " + filename, shell=True) #extract the .tar.gz file
 
-dirname_bin = dirname + "_build"
+dirname_bin = dirname
 final_dirname = "boost_build"
 
-try:
-    shutil.rmtree(dirname_bin)
-except:
-    pass
-
 try:
     shutil.rmtree(final_dirname)
 except:

ci_scripts/test_linux-daemon-cmake.py

@@ -14,7 +14,7 @@
 packages_to_install = \
 [
 "ccache",
-"qt5-default",
+"qtbase5-dev",
 "qt5-qmake",
 "qtbase5-dev-tools",
 "qttools5-dev-tools",
@@ -43,7 +43,10 @@
 "python3-setuptools",
 "wget",
 "cmake",
-"nano"
+"nano",
+"libudev-dev",
+"libusb-1.0-0-dev",
+"libhidapi-dev"
 ]
 
 nci.install_packages_debian(packages_to_install)