fix(profile): dedupe sign-section axis legend + fix blurb grammar#477
Open
Necmttn wants to merge 1 commit into
Open
fix(profile): dedupe sign-section axis legend + fix blurb grammar#477Necmttn wants to merge 1 commit into
Necmttn wants to merge 1 commit into
Conversation
The sign section printed axis definitions twice - the under-chart legend
AND inline notes in the raw-values table. Keep the legend (it sits next
to the cryptic spoke labels and the score bars), revert the raw-values
table to clean metric/value rows.
Also fix the blurb grammar: "it's 29.6% of your sessions land clean work
and 22.9B tokens moved that wrote this chart" -> "...sessions LANDING
clean work...", a gerund noun-phrase that matches the other axis facts
("tokens moved", "subagents dispatched").
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Deploying ax with
|
| Latest commit: |
10bab36
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e9dad5b7.ax-62d.pages.dev |
| Branch Preview URL: | https://feat-sign-design-polish.ax-62d.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design-review follow-up to #475, verified live against a local preview of
/u/supnim.Two fixes
1. Axis definitions printed twice. #475 added both an under-chart legend and inline notes in the raw-values table — same text in two places. Keep the legend (it's next to the cryptic spoke labels + the score bars), revert the raw-values table to clean metric/value rows.
2. Blurb grammar. "it's 29.6% of your sessions land clean work and 22.9B tokens moved that wrote this chart" → "...sessions landing clean work...". Gerund noun-phrase, matching the other axis facts ("tokens moved", "subagents dispatched").
Verification
Rendered locally (vite preview) and screenshotted — blurb reads correctly, raw-values table is clean, legend retained.
@ax/sitebuild green; 23 radar tests pass.🤖 Generated with Claude Code