Skip to content

Conversation

@bmcorser
Copy link

@bmcorser bmcorser commented Feb 5, 2015

Good

  • The code might work?

Bad

  • No packaging integration
  • Can't run tests without 10GB of data?
  • Running tests as described in docs fails with ImportError
  • Code doesn't compile AttributeError: _Environ instance has no __call__ method cf7140f
  • Code doesn't pass PEP8
  • Illegible syntax
  • Single character variable names in nested loops aren't readable even if
    they're not in a convoluted list comp
  • "Predictably" formatted strings used instead of
    data
    structures!?
  • Reticent to assign? 438f80a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant