feat: new voices and wakewords#88
Conversation
|
|
||
| def initialize(self): | ||
| self.bus.on("mycroft.ready", self._speak_restart_dialog) | ||
| if self.dialog_to_speak and self.pending_audio_restart: |
There was a problem hiding this comment.
If this happens before the audio module is ready, I believe the dialog may be lost.. The on("mycroft.ready") should handle it in any case so this appears to be redundant anyways
There was a problem hiding this comment.
See above, audio should always be ready before skills load in a Mark 2, so this is the primary and mycroft.ready is the fallback. mycroft.ready hasn't always been consistent for me so that's why I made this primary
|
Regarding the test failure, can you log |
|
I got a "sorry, something has gone wrong. I will continue using-" followed by services restarting. audio.log skills.log It seems there's something going on with disabling the old WW before enabling the new one which causes an error to avoid a state where there is no active WW. UPDATE: I'll install that and try again |
Allows NeonGeckoCom/skill-device_controls#88 to succeed, among other things
Description
Allows users to use one of three presets for voice/wakeword combinations:
Issues
#87
Other Notes
N/A