perf(render): migrate NewsFlashesPage to the selector store - #432
Conversation
|
Warning Review limit reached
Next review available in: 59 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthrough
ChangesNewsFlashesPage store migration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized refactor changes how NewsFlashesPage subscribes to store data and actions without any supplied evidence of a current correctness or production risk; no actionable merge-blocking risk remains. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@CodeRabbit review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Six data slices now come from one useStoreSelector and the three news-flash actions from the stable useStoreActions context, replacing five whole-domain hook subscriptions that re-rendered the page on unrelated updates. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
The roster domain hooks filtered soft-deleted rows; the selector-store migration read raw slices. Restore the active-student filtering so archived students can't be selected as news-flash recipients. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
ce8d679 to
7e57867
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
|
@CodeRabbit review |
|
1 participant
What
Migrates
NewsFlashesPagefrom five whole-domain hooks to oneuseStoreSelectorfor its six data slices (students,rubrics,tests,newsFlashes,newsFlashReads,flashcardDecks) plususeStoreActionsforaddNewsFlash/updateNewsFlash/deleteNewsFlash.Why
Whole-domain subscriptions re-rendered the page on every unrelated collection update; it now re-renders only when one of the slices it renders changes.
Notes
Stacked on #431 (part of the roadmap "Up Next" selector-store series).