Support ScaleType for Storage Pools and ONTAP mode pools#29
Open
gnaveen-netapp wants to merge 1 commit into
Open
Support ScaleType for Storage Pools and ONTAP mode pools#29gnaveen-netapp wants to merge 1 commit into
gnaveen-netapp wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates storage pool creation to model “large capacity” as a scaleType on FLEX+UNIFIED pools (instead of a separate UNIFIED_LARGE_CAPACITY pool type), aligning validation, documentation, and tests with the newer NetApp API surface.
Changes:
- Remove
UNIFIED_LARGE_CAPACITYfromstoragePoolTypeinputs and handler parsing; update related error messages. - Add
scaleTypeinput support for storage pool creation and include it in the create request payload (with new validation/tests). - Bump
@google-cloud/netappdependency to^0.18.0and update docs (README/GEMINI) to describe the new model.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tools/storage-pool-tools.ts | Removes UNIFIED_LARGE_CAPACITY from storagePoolType and adds scaleType to the create tool input schema. |
| src/tools/storage-pool-tools.test.ts | Updates schema validation tests for removed pool type and new scaleType. |
| src/tools/handlers/storage-pool-handler.ts | Removes old enum mapping and adds scaleType parsing/validation + request payload wiring. |
| src/tools/handlers/storage-pool-handler.test.ts | Adds coverage for scaleType normalization/validation and payload inclusion; updates UNIFIED/FLEX error expectations. |
| README.md | Updates service-level guidance and documents storagePoolType/scaleType. |
| package.json | Bumps @google-cloud/netapp to ^0.18.0. |
| package-lock.json | Locks @google-cloud/netapp to 0.18.0. |
| GEMINI.md | Updates guidance to reflect UNIFIED + scaleType for large capacity instead of UNIFIED_LARGE_CAPACITY. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
There was a problem hiding this comment.
Please add ontap mode pool creation support as part of this PR.
Collaborator
Author
There was a problem hiding this comment.
Added ontap mode pool creation support
8d2f660 to
26cee5d
Compare
26cee5d to
8462369
Compare
8462369 to
2a21411
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for the
scaleTypeandmodefields when creating and managing NetApp FLEX UNIFIED storage pools, removes support for the deprecatedUNIFIED_LARGE_CAPACITYstorage pool type. The most important changes are summarized below:scaleTypeas an optional input to thecreateStoragePoolHandler, with validation to ensure it is only used with FLEX UNIFIED pools and only accepts valid enum values (SCALE_TYPE_DEFAULT,SCALE_TYPE_SCALEOUT,SCALE_TYPE_UNSPECIFIED).modefield (Default vs ONTAP expert mode).Dependency update:
@google-cloud/netappdependency from version 0.16.0 to 0.18.0 inpackage.json.