Skip to content

Support ScaleType for Storage Pools and ONTAP mode pools#29

Open
gnaveen-netapp wants to merge 1 commit into
NetApp:mainfrom
gnaveen-netapp:scaleTypeSupport
Open

Support ScaleType for Storage Pools and ONTAP mode pools#29
gnaveen-netapp wants to merge 1 commit into
NetApp:mainfrom
gnaveen-netapp:scaleTypeSupport

Conversation

@gnaveen-netapp
Copy link
Copy Markdown
Collaborator

@gnaveen-netapp gnaveen-netapp commented May 15, 2026

This pull request introduces support for the scaleType and mode fields when creating and managing NetApp FLEX UNIFIED storage pools, removes support for the deprecated UNIFIED_LARGE_CAPACITY storage pool type. The most important changes are summarized below:

  • Added scaleType as an optional input to the createStoragePoolHandler, with validation to ensure it is only used with FLEX UNIFIED pools and only accepts valid enum values (SCALE_TYPE_DEFAULT, SCALE_TYPE_SCALEOUT, SCALE_TYPE_UNSPECIFIED).
  • Introduced support for the mode field (Default vs ONTAP expert mode).

Dependency update:

  • Upgraded @google-cloud/netapp dependency from version 0.16.0 to 0.18.0 in package.json.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates storage pool creation to model “large capacity” as a scaleType on FLEX+UNIFIED pools (instead of a separate UNIFIED_LARGE_CAPACITY pool type), aligning validation, documentation, and tests with the newer NetApp API surface.

Changes:

  • Remove UNIFIED_LARGE_CAPACITY from storagePoolType inputs and handler parsing; update related error messages.
  • Add scaleType input support for storage pool creation and include it in the create request payload (with new validation/tests).
  • Bump @google-cloud/netapp dependency to ^0.18.0 and update docs (README/GEMINI) to describe the new model.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/tools/storage-pool-tools.ts Removes UNIFIED_LARGE_CAPACITY from storagePoolType and adds scaleType to the create tool input schema.
src/tools/storage-pool-tools.test.ts Updates schema validation tests for removed pool type and new scaleType.
src/tools/handlers/storage-pool-handler.ts Removes old enum mapping and adds scaleType parsing/validation + request payload wiring.
src/tools/handlers/storage-pool-handler.test.ts Adds coverage for scaleType normalization/validation and payload inclusion; updates UNIFIED/FLEX error expectations.
README.md Updates service-level guidance and documents storagePoolType/scaleType.
package.json Bumps @google-cloud/netapp to ^0.18.0.
package-lock.json Locks @google-cloud/netapp to 0.18.0.
GEMINI.md Updates guidance to reflect UNIFIED + scaleType for large capacity instead of UNIFIED_LARGE_CAPACITY.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/tools/handlers/storage-pool-handler.ts Outdated
Comment thread src/tools/handlers/storage-pool-handler.ts Outdated
Comment thread src/tools/storage-pool-tools.ts Outdated
Comment thread src/tools/handlers/storage-pool-handler.test.ts
Comment thread README.md Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add ontap mode pool creation support as part of this PR.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added ontap mode pool creation support

Copilot AI review requested due to automatic review settings May 15, 2026 18:41
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Comment thread src/tools/handlers/storage-pool-handler.ts Outdated
Comment thread src/tools/handlers/storage-pool-handler.test.ts
Comment thread src/tools/storage-pool-tools.test.ts
@gnaveen-netapp gnaveen-netapp changed the title Support ScaleType for Storage Pools Support ScaleType for Storage Pools and ONTAP mode pools May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants