Replace pkg_resources with importlib.resources#27
Merged
samvelyan merged 2 commits intoNetHack-LE:mainfrom Jul 14, 2025
Merged
Conversation
This resolves "UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81."
Reason: importlib.resources.files is only available in Python>=3.9
codingWhale13
force-pushed
the
replace-pkg_resources
branch
from
a9cb582 to
2d4945a
Compare
Collaborator
|
Thank @codingWhale13 for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves "UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81".
Note: importlib.resources requires Python ≥3.7, same as MiniHack (see setup.py).
EDIT: It turns out that importlib.resources.files requires Python ≥3.9 so the next best thing is to use its backport
importlib-resources, which adds an extra dependency.