Use xdist for faster multi-processing-based tests#102
Closed
jbcoe wants to merge 3 commits intoNetHack-LE:mainfrom
Closed
Use xdist for faster multi-processing-based tests#102jbcoe wants to merge 3 commits intoNetHack-LE:mainfrom
jbcoe wants to merge 3 commits intoNetHack-LE:mainfrom
Conversation
This commit resolves a non-determinism issue in `TtyrecDataset` where the order of loaded games could vary between runs. The previous implementation used a single data loading function with a shared lock (`threading.Lock`) for all workers. This created a race condition where multiple threads competed to fetch the next game, resulting in an unpredictable data order. The fix introduces a deterministic assignment of games to each worker: - A new `_make_load_fns` method creates a separate, dedicated data loading function for each batch dimension. - Each function is assigned a unique, non-overlapping sequence of games by striding over the global `gameids` list. This eliminates the need for a shared lock and guarantees a deterministic loading order. The corresponding tests in `test_minibatches` have also been updated to validate this new, deterministic behavior.
jbcoe
force-pushed
the
jbcoe/pytest-xdist
branch
from
51d1a4a to
7438848
Compare
Author
|
This disables benchmarks which was the slow bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #104 to be merged first.
Some issues around benchmarks need investigating (they are currently auto-disabled).