Invoke-HuntSQLServers - Standardize output file naming, improve shared SQL account handling#8
Open
missing0x00 wants to merge 2 commits intoNetSPI:masterfrom
Open
Invoke-HuntSQLServers - Standardize output file naming, improve shared SQL account handling#8missing0x00 wants to merge 2 commits intoNetSPI:masterfrom
missing0x00 wants to merge 2 commits intoNetSPI:masterfrom
Conversation
Fix name consistency between console output and actual file.
1. Create summary report even if no instances are accessible 2. Deduplicate SPNs by ComputerName,DomainAccount (should also avoid issues from instances run using Machine$ accounts) 3. Move Shared Account processing into Instance Discovery section (summary adjusted to match)
missing0x00
changed the title
Author
|
Copying the more substantial changes out of the commit message for visibility:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Console output and actual file name did not align.
Possibly, theoretically, someone could spend way too much time hunting a bug that was more about searching for the wrong file name... 🙃