Skip to content

Fix kmhtml css#157

Merged
mxjp merged 4 commits into
masterfrom
fix-kmhtml-css
Jul 7, 2025
Merged

Fix kmhtml css#157
mxjp merged 4 commits into
masterfrom
fix-kmhtml-css

Conversation

@mxjp

@mxjp mxjp commented Jul 7, 2025

Copy link
Copy Markdown
Member

No description provided.

@Sayan751 Sayan751 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

suiteContainer.appendChild(this.createSpecResult(test, $class, error));
const specResult = this.createSpecResult(test, $class, error);
suiteContainer.appendChild(specResult);
span.addEventListener('click', () => {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Comment thread tsconfig.json
"ESNext",
"dom"
],
"module": "commonjs",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is commonjs still needed?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because the karma config is still commonjs and loading es modules there is more complicated.

@mxjp
mxjp marked this pull request as ready for review July 7, 2025 11:52
@mxjp
mxjp merged commit e49f4a3 into master Jul 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants