Provide default host name for ingress#211
Merged
DmitriiRabenok merged 2 commits intomainfrom Mar 2, 2026
Merged
Conversation
theboringstuff
changed the title
theboringstuff
assigned
theboringstuff and
DmitriiRabenok and unassigned
theboringstuff
theboringstuff
requested review from
pranavcracker
and removed request for
DmitriiRabenok
pranavcracker
approved these changes
Feb 27, 2026
DmitriiRabenok
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, site-manager deploys with empty Ingress hostname by default, which is problem for multiple reasons, but especially because we can not deploy two site-manager instances with default parameters on the same env in different namespaces
Solution
site-manager-${.Release.Namespace}.${.Values.CLOUD_PUBLIC_HOST}. Normally, this should not be backward compatibility problem, because relying on empty hostname was incorrect.