This repository was archived by the owner on Dec 5, 2025. It is now read-only.
fix: deprecate LISTEN_ADDR in pg_template.yaml#33
Open
vlsi wants to merge 1 commit intoNetcracker:mainfrom
Open
fix: deprecate LISTEN_ADDR in pg_template.yaml#33vlsi wants to merge 1 commit intoNetcracker:mainfrom
vlsi wants to merge 1 commit intoNetcracker:mainfrom
Conversation
hostname -i` might print multiple IP addresses separated with space, so it is a bad fit for the listen address. We should better use `*:port` for listen address, which is a static value. An environment variable with a static value does not help much. We'd better deprecate and remove LISTEN_ADDR variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hostname -i
might print multiple IP addresses separated with space, so it is a bad fit for the listen address. We should better use*:port` for listen address, which is a static value. An environment variable with a static value does not help much.We'd better deprecate and remove
LISTEN_ADDRvariable.Here's the PR for the removal of
LISTEN_ADDR: Netcracker/pgskipper-operator#103