Open
Conversation
added 2 commits
November 12, 2024 10:51
🦋 Changeset detectedLatest commit: a837026 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Collaborator
|
感谢贡献～🎉🎉🎉 |
CaedmonW
requested changes
Nov 12, 2024
Comment on lines
+12
to
+18
| font-size: $--font-size-2; | ||
| line-height: 1.1; | ||
| text-align: left; | ||
|
|
||
| &--sub { | ||
| color: $--desc-timeline-color; | ||
| font-size: $--font-size-1; |
Collaborator
There was a problem hiding this comment.
默认的 font-size 对移动端来说有点小了
Comment on lines
+49
to
+67
| <View className={classNames(dotClass)}> | ||
| {icon && <OsIcon | ||
| className={classNames(`ossa-icon--${icon}`)} | ||
| type={icon} | ||
| customStyle={{ color: iconColor }} | ||
| size={16} | ||
| ></OsIcon>} | ||
| </View> | ||
| <View className='ossa-timeline-item__content'> | ||
| <View className='ossa-timeline-item__content-item'>{title}</View> | ||
| {content.map((sub, subIndex) => ( | ||
| <View | ||
| className='ossa-timeline-item__content-item ossa-timeline-item__content--sub' | ||
| key={subIndex} | ||
| > | ||
| {sub} | ||
| </View> | ||
| ))} | ||
| </View> |
| import { OsTimelineProps } from "../../../types/index"; | ||
|
|
||
| function getClassObject(props: OsTimelineProps) { | ||
| const { pending = false } = props; |
Collaborator
There was a problem hiding this comment.
组件维度的 pending 属性，似乎不是很合理
Author
There was a problem hiding this comment.
需要有一个属性用来判断节点是否完成，这里你建议用什么方式来做？
Collaborator
There was a problem hiding this comment.
感觉timeline单纯控制最后一个的状态有点鸡肋，像steps一样每个节点都有自己的状态实用性会更好些
| height: $--dot-timeline-size; | ||
| border: 1PX solid transparent; | ||
| border-radius: 10px; | ||
| border-color: $--timeline-dot-border-color; |
Author
There was a problem hiding this comment.
颜色这里我刚开始使用默认主题色的，但是考虑到节点的完成/错误/警告等样式会跟默认主题色重复，所以用了蓝色处理，这里你建议怎么优化下？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
add timeline
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: