Fix Gradle configuration cache regression from #918#934
Open
mrmegapolys wants to merge 1 commit intoNetflix:masterfrom
Open
Fix Gradle configuration cache regression from #918#934mrmegapolys wants to merge 1 commit intoNetflix:masterfrom
mrmegapolys wants to merge 1 commit intoNetflix:masterfrom
Conversation
mrmegapolys
requested review from
asibross,
iparadiso,
iuliiasobolevska,
jjacobs44,
kilink,
kzwang,
paulbakker and
srinivasankavitha
as code owners
mrmegapolys
force-pushed
the
fix/configuration-cache-jackson-detection
branch
from
4c4b60c to
a209810
Compare
mrmegapolys
force-pushed
the
fix/configuration-cache-jackson-detection
branch
from
a209810 to
949c923
Compare
JacksonVersionDetector.detectVersions(project) was called in the @TaskAction method, accessing Task.project at execution time which is unsupported with configuration cache. Move Jackson version detection to configuration time by adding a @input property to GenerateJavaTask and resolving it in the plugin afterEvaluate block. Fixes Netflix#933
mrmegapolys
force-pushed
the
fix/configuration-cache-jackson-detection
branch
from
949c923 to
dde1322
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JacksonVersionDetector.detectVersions(project)was called in the@TaskAction generate()method, accessingTask.projectat execution time — unsupported with Gradle configuration cache.Moves Jackson version detection to configuration time by adding a
@Input jacksonVersionsproperty toGenerateJavaTaskand resolving it in the plugin'safterEvaluateblock (afterClientUtilsConventionsto avoid resolvingcompileClasspathbefore all dependencies are declared).Fixes #933