Open
Conversation
Contributor
Author
|
@ipapapa ready for review |
amcp
commented
Oct 14, 2018
| super(awsCredentialsProvider, configuration); | ||
| } | ||
|
|
||
| protected void createAndSetDynamoDBClient() { |
Contributor
Author
There was a problem hiding this comment.
add a comment and explain why protected
| this.dynamoDB = dynamoDbBuilder.build(); | ||
| } | ||
|
|
||
| protected void instantiateDataPlaneOperations(DataGenerator dataGenerator) { |
Contributor
Author
There was a problem hiding this comment.
add a java doc and explain why protected
| refresh(); | ||
| return credentialsProvider.resolveCredentials(); | ||
| } | ||
| } No newline at end of file |
Contributor
Author
|
also, add a test for v2 operations? |
ipapapa
reviewed
Oct 14, 2018
| compile "com.amazonaws:aws-java-sdk-applicationautoscaling:latest.release" | ||
| compile "com.amazonaws:aws-java-sdk-sts:latest.release" | ||
| compile "com.amazonaws:aws-java-sdk-cloudwatch:latest.release" | ||
| compile "software.amazon.awssdk:dynamodb:latest.release" |
Contributor
There was a problem hiding this comment.
Whys is this package different from the standard com.amazonaws?
ipapapa
reviewed
Oct 14, 2018
| * @author Alexander Patrikalakis | ||
| */ | ||
| @Singleton | ||
| @NdBenchClientPlugin("DynamoDBv2KeyValue") |
Contributor
There was a problem hiding this comment.
Do we have in the documentation the difference between V1 and V2? Are we going to keep eventually both of them or just V2?
Contributor
|
It seems there are some comments in some places, I assume this is a WIP? Has the PR been functionally tested? cc'ing @sumanth-pasupuleti. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #147