Adds ssl capability for cassandra connectivity#247
Open
vaibhavkhurana2018 wants to merge 2 commits intoNetflix:masterfrom
Open
Adds ssl capability for cassandra connectivity#247vaibhavkhurana2018 wants to merge 2 commits intoNetflix:masterfrom
vaibhavkhurana2018 wants to merge 2 commits intoNetflix:masterfrom
Conversation
vaibhavkhurana2018
force-pushed
the
master
branch
from
fb32280 to
7e96547
Compare
Contributor
vinaykumarchella
left a comment
vinaykumarchella
left a comment
There was a problem hiding this comment.
Thank you for submitting the patch, the first pass looks good, left a few comments.
| @PropertyName(name = "truststorePath") | ||
| String getTruststorePath(); | ||
|
|
||
| @PropertyName(name = "truststorePass") |
Contributor
There was a problem hiding this comment.
@PropertyName annotations here are redundant since the overridden name is not different from the method name
| PoolingOptions poolingOpts = new PoolingOptions() | ||
| .setConnectionsPerHost(HostDistance.LOCAL, connections, connections) | ||
| .setMaxRequestsPerConnection(HostDistance.LOCAL, 32768); | ||
| KeyStore ks = null; |
Contributor
There was a problem hiding this comment.
You might want to do null check here for truststorePath and truststorePass before constructing sslContext to avoid exceptions during non SSL scenarios.
nit: Good to keep an abstract method for getSSLContext() in CassJavaDriverManagerImpl.java and implement in this since the internal implementation can provide their own way of getting SSLContext in their organizations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for supporting client to node SSL connectivity from ndbench to cassandra. This accepts 2 variables, truststorePath and truststorePass.
Add variable config
Update
registerClustermethod to accept the new variables and do a cluster build with the SSL Options given.Update all the callers for the function
Test connectivity with a cassandra cluster with SSL enabled.