Added readRateLimit and writeRateLimit as config params to CliConfigs#263
Open
KnifeyMoloko wants to merge 1 commit intoNetflix:masterfrom
Open
Added readRateLimit and writeRateLimit as config params to CliConfigs#263KnifeyMoloko wants to merge 1 commit intoNetflix:masterfrom
KnifeyMoloko wants to merge 1 commit intoNetflix:masterfrom
Conversation
Contributor
|
Thanks for the contribution. As far as I can tell, these configuration values will not be applied to the actual test because they aren't passed to the driver in NdbenchCli. If we add new configuration parameters, we should make sure the driver respects them; also we should add documentation for the new configuration parameters. I'm happy to make suggestions on how to do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for writeRateLimit and readRateLimit properties for ndbench CLI.