Open
Conversation
joshgord
commented
Nov 14, 2023
| if (!(superclass instanceof ParameterizedType)) { | ||
| throw new IllegalArgumentException(superclass + " isn't parameterized"); | ||
| } | ||
| this.type = (Class<T>) ((ParameterizedType) superclass).getActualTypeArguments()[0]; |
Author
There was a problem hiding this comment.
This is probably one of the only changes that I am not completely confident in, looks like the tests were happy with this change but not sure of other usages not covered in test cases
joshgord
commented
Nov 23, 2023
| * @deprecated use {@link #getEntity(Type)} | ||
| */ | ||
| @Deprecated | ||
| public <T> T getEntity(TypeToken<T> type) throws Exception; |
Author
There was a problem hiding this comment.
This is a breaking change because we leaked guava into the public interface, looks like this is deprecated with a replacement so removal of this method will unlock guava removal
joshgord
changed the title
joshgord
changed the title
joshgord
commented
Nov 23, 2023
| api "com.netflix.servo:servo-core:${servo_version}" | ||
| api "com.google.guava:guava:${guava_version}" | ||
| api 'com.netflix.netflix-commons:netflix-commons-util:0.1.1' | ||
| api 'com.github.ben-manes.caffeine:caffeine:2.9.2' |
Author
There was a problem hiding this comment.
Not sure if we have to involve lawyers but this does change our license structure slightly. The fact that it is used in Spring and Cassandra likely means it's probably permissible.
Author
|
Is there a process for a review and/or merge for this project? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used openrewrite to remove most usages of guava. The loadbalancer project uses a loading cache which we need to keep in place but I reduced the transitive graph by only pulling in guava in that subproject.