fix UdpWriter log flooding on thread interrupt#1227
Merged
brharrington merged 1 commit intoNetflix:mainfrom Mar 11, 2026
Merged
fix UdpWriter log flooding on thread interrupt#1227brharrington merged 1 commit intoNetflix:mainfrom
brharrington merged 1 commit intoNetflix:mainfrom
Conversation
In Spark, executor threads get interrupted for task cancellation. ClosedByInterruptException closes the UDP channel and sets the thread interrupt flag. The reconnect attempt always fails because the thread is still interrupted, logging a WARN on every write. - Catch ClosedByInterruptException separately and skip reconnection since it will always fail while the thread is interrupted - Remove WARN logs from writeImpl that bypassed the suppressWarnings mechanism in SidecarWriter.write(), which could cause flooding on any repeated reconnection failure (e.g., FD exhaustion)
jzhuge
approved these changes
Mar 11, 2026
Contributor
jzhuge
left a comment
jzhuge
left a comment
There was a problem hiding this comment.
IIUC, the new flow is
writeImpl → ClosedByInterruptException → re-thrown (no WARN in UdpWriter)
→ caught by SidecarWriter.write()'s catch (IOException e)
→ 1st time: logs WARN, suppressWarnings = true
→ 2nd+ time: suppressed ✓
This should be able to fix the flooding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Spark, executor threads get interrupted for task cancellation. ClosedByInterruptException closes the UDP channel and sets the thread interrupt flag. The reconnect attempt always fails because the thread is still interrupted, logging a WARN on every write.
Catch ClosedByInterruptException separately and skip reconnection since it will always fail while the thread is interrupted
Remove WARN logs from writeImpl that bypassed the suppressWarnings mechanism in SidecarWriter.write(), which could cause flooding on any repeated reconnection failure (e.g., FD exhaustion)