fix: restore perf-devnet-3 genesis content (stranded LFS pointer) - #154
Open
kamilchodola wants to merge 1 commit into
Open
fix: restore perf-devnet-3 genesis content (stranded LFS pointer)#154kamilchodola wants to merge 1 commit into
kamilchodola wants to merge 1 commit into
Conversation
PR #143 committed the literal Git LFS pointer text as a normal blob and the referenced LFS object was never uploaded, so every workflow run on main since then hands Nethermind a 135-byte pointer file as its chainspec and the node dies at startup with "'v' is an invalid start of a value". Test generation never reads this file, which is why Release Workstream kept succeeding. Restores the real JSON (the version validated against the perf-devnet-3 runner snapshot by the working Amsterdam benchmark branch).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #143 committed the literal Git LFS pointer text for
scripts/genesisfiles/nethermind/generator-amsterdam-perf-devnet-3.jsonas a normal blob (135 bytes,version https://git-lfs.github.com/spec/v1...), and the referenced LFS object (e15580a6…) was never uploaded —git lfs pullcannot fetch it and.gitattributesdoesn't even track this path.Consequence: every
repricing-nethermindrun onmainfor perf-devnet-3 hands Nethermind the pointer file as its chainspec; the node dies at startup with'v' is an invalid start of a valueinChainSpecLoaderand the RPC never comes up, so all tests get skipped. Test generation (Release Workstream) never reads this file, which is why osaka-repricings releases kept building fine while runs fail.This restores the real JSON — the version currently validated against the perf-devnet-3 runner snapshot by the working Amsterdam benchmark branch (
increase-batch-tx-limit): the pre-pointer content from6b0db651plus the four Amsterdam EIP activation timestamps (eip8037/7954/7976/7981).Unblocks running osaka-repricings-v1.2.0 stateful benchmarks from
main.