Ideal checks reworked to only work with binary polynomials#101
Draft
frozenspider wants to merge 13 commits into
Draft
Ideal checks reworked to only work with binary polynomials#101frozenspider wants to merge 13 commits into
frozenspider wants to merge 13 commits into
Conversation
|
Coverage (base → head): |
frozenspider
changed the title
frozenspider
requested review from
ElijahVlasov,
albert-garreta and
osdnk
as code owners
…checks # Conflicts: # piop/src/ideal_check.rs # piop/src/ideal_check/combined_poly_builder.rs # piop/src/ideal_check/structs.rs # test-uair/src/lib.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we only need ideal checks to work with binary polynomials, code has been reworked to work with it specifically instead of variants of
DensePolynomial.Other changes:
TestAirNoMultiplicationand introducedTestAirBinaryto replace it (thanks @ElijahVlasov for the idea!)CoefficientProjectableandto_u64to both versions ofBinaryPolyIdealOrZerochanged to be an enumNote that this does not include any performance optimizations per se, other than what we're getting for free from this change.
closes #88