fix: reduce fds for daemon db connections#584
Open
damonhayhurst-neuraco wants to merge 1 commit into
Open
Conversation
damonhayhurst-neuraco
added
the
version:minor
Contributor
|
Consider updating changelogs/pending-changelog.md with a summary of this change for the release notes. This is optional and non-blocking. |
CougarTasker
approved these changes
Apr 29, 2026
| self._engine: AsyncEngine = create_async_engine( | ||
| f"sqlite+aiosqlite:///{db_path}", | ||
| future=True, | ||
| pool_size=1, |
Member
There was a problem hiding this comment.
Question: can you check this pool size and how it effects performance, try a few values and see how it effects perfomace timings
damonhayhurst-neuraco
force-pushed
the
fix/reduce-fds-for-dbs-connections
branch
from
3b9c975 to
f92ec37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
Justification