feat: integration test fail on error in logs#612
Open
sdas-neuraco wants to merge 2 commits into
Open
Conversation
Comment on lines
+612
to
+618
| job_id, max_entries=10, severity_filter="ERROR" | ||
| ) | ||
| assert "logs" in filtered | ||
| assert not filtered["logs"], ( | ||
| "Training VM emitted ERROR logs while RUNNING:\n\n" | ||
| f"{_format_training_log_entries(filtered['logs'])}" | ||
| ) |
Contributor
There was a problem hiding this comment.
i feel there is a bit of repetition here since we introduced this function _assert_no_training_log_errors and it seemed like it does something similar yet not being used which caused some confusion to me. if it cant be used please leave a comment why, and if can maybe it's better to refactor to use it
Contributor
Author
There was a problem hiding this comment.
agree, this was mainly to chek only errors in log for max_entries=10 while the other uses critial and error, with better formatting
mark-neuracore
approved these changes
May 14, 2026
Contributor
mark-neuracore
left a comment
mark-neuracore
left a comment
There was a problem hiding this comment.
LGTM w/c
left my comments earlier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features