test: fix and refactor training flow test#614
Merged
Conversation
aditya-neuraco
added
the
version:none
aditya-neuraco
force-pushed
the
test/fix-and-refactor-training-flow-test
branch
2 times, most recently
from
4c33cc7 to
071b4b6
Compare
muneebneura
approved these changes
May 13, 2026
Contributor
muneebneura
left a comment
muneebneura
left a comment
There was a problem hiding this comment.
LGTM w/comments
Also, you have mentioned adding a new test, TestTrainingFlowSmoke in the pr description which I couldn't find in your changes?
aditya-neuraco
force-pushed
the
test/fix-and-refactor-training-flow-test
branch
from
071b4b6 to
d43e49d
Compare
sdas-neuraco
force-pushed
the
test/fix-and-refactor-training-flow-test
branch
from
d43e49d to
c3b5da3
Compare
Contributor
Author
Sorry, that file was just for testing locally. Removed it from PR description. Thanks for pointing it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
TestTrainingFlow,TestTrainingFailureReporting,TestBackToBackTraining) with each step as a separatetest_step*method for granular CI failure reporting_build_cross_embodiment_descriptionshelper, eliminating duplication across test classes_wait_for_traininginto_wait_for_training(single job) and_wait_for_all_training(multiple jobs)Bugfixes
RUNNING_STATE_TIMEOUT_MINUTES,LOGS_AVAILABILITY_TIMEOUT_MINUTES,JOB_STATE_POLL_SECONDS,ENDPOINT_TTL_SECONDS,LOCAL_SERVER_PORT, etc.)t += 0.02tot += 1.0 / FREQUENCYso timestep is derived from the frequency constantassert self.X is not Noneguards before each step that depends on prior state, giving clear failure messages when steps run out of orderItems