Skip to content

fix: importer overwrite should wait for dataset to complete deletion#617

Merged
ypang-neuraco merged 1 commit into
mainfrom
fix/importer-overwrite-wait
May 13, 2026
Merged

fix: importer overwrite should wait for dataset to complete deletion#617
ypang-neuraco merged 1 commit into
mainfrom
fix/importer-overwrite-wait

Conversation

@ypang-neuraco
Copy link
Copy Markdown
Contributor

Bugfixes

  • Importer has overwrite option to delete existing dataset with the same name and create a new one
  • Dataset deletion request is sent but does not wait for deletion to complete before creating new one causing error on dataset creation
  • This fix tries to create the new dataset at a fixed time interval until it is successfully created

@ypang-neuraco ypang-neuraco self-assigned this May 13, 2026
@ypang-neuraco ypang-neuraco added the version:patch non-breaking bug fixes; no input/output changes (except defaults) label May 13, 2026
Copy link
Copy Markdown
Contributor

@aditya-neuraco aditya-neuraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! w/ comments

Comment thread tests/unit/importer/test_importer.py
Comment thread neuracore/importer/importer.py
@ypang-neuraco ypang-neuraco force-pushed the fix/importer-overwrite-wait branch from dd49d17 to b280571 Compare May 13, 2026 14:25
@ypang-neuraco ypang-neuraco merged commit 460a0af into main May 13, 2026
10 checks passed
@ypang-neuraco ypang-neuraco deleted the fix/importer-overwrite-wait branch May 13, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:patch non-breaking bug fixes; no input/output changes (except defaults)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants