Add gap_tolerance_ms API to Neuralynx reader#1822
Open
h-mayorquin wants to merge 1 commit intoNeuralEnsemble:masterfrom
Open
Add gap_tolerance_ms API to Neuralynx reader#1822h-mayorquin wants to merge 1 commit intoNeuralEnsemble:masterfrom
gap_tolerance_ms API to Neuralynx reader#1822h-mayorquin wants to merge 1 commit intoNeuralEnsemble:masterfrom
Conversation
Contributor
|
This is heroic! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
gap_tolerance_msparameter toNeuralynxRawIOandNeuralynxIO, following the pattern established by the Blackrock reader in #1789. When gaps are detected and no tolerance is set, aValueErroris raised with a detailed gap report. When a tolerance is provided, the data is automatically segmented at gaps exceeding that threshold. The oldstrict_gap_modeparameter is deprecated with a warning. By default (gap_tolerance_ms=None), only gaps of at least one sample period are reported as errors; sub-sample timestamp deviations from rounding or clock jitter are silently ignored.A
_get_neuralynx_timestamps()method exposes the original per-record hardware timestamps in microseconds, giving users access to the raw timing information for drift analysis or precise alignment with external systems.The test infrastructure gains
rawio_kwargsonBaseTestRawIOandio_kwargsonBaseTestIO, allowing any format's tests to pass constructor arguments without overriding test methods or subclassing the IO class.