Update for python3 and move top level into if block#2
Open
simeonmiteff wants to merge 1 commit intoNeurodataWithoutBorders:masterfrom
simeonmiteff:master
Open
Update for python3 and move top level into if block#2simeonmiteff wants to merge 1 commit intoNeurodataWithoutBorders:masterfrom simeonmiteff:master
simeonmiteff wants to merge 1 commit intoNeurodataWithoutBorders:masterfrom
simeonmiteff:master
Conversation
- Update the print statements to python3 style - Replace iteritems() to items() (python3) - Move the top level code into `if __name__=="__main__":` block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made some changes to be able to import ndiff as a module into an existing python3 project.
if __name__=="__main__":block.Not sure if you'd need additional updates to the README or elsewhere (#! line?) to explicitly require python3. Hope this is useful.