Add get_duration and get_starting_time for Units table#2164
Draft
h-mayorquin wants to merge 3 commits intodevfrom
Draft
Add get_duration and get_starting_time for Units table#2164h-mayorquin wants to merge 3 commits intodevfrom
get_duration and get_starting_time for Units table#2164h-mayorquin wants to merge 3 commits intodevfrom
Conversation
h-mayorquin
changed the title
get_duration and get_starting_time for Units table
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2164 +/- ##
==========================================
- Coverage 95.28% 94.88% -0.40%
==========================================
Files 29 29
Lines 2904 2951 +47
Branches 748 760 +12
==========================================
+ Hits 2767 2800 +33
- Misses 83 89 +6
- Partials 54 62 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bendichter
reviewed
Feb 4, 2026
| ut.add_unit(spike_times=[1.0, 2.0, 20.0]) # has BOTH earliest (1.0) AND latest (20.0) | ||
| ut.add_unit(spike_times=[10.0, 11.0, 12.0]) | ||
| # Duration from earliest (1.0) to latest (20.0) = 19.0 | ||
| self.assertEqual(ut.get_duration(), 19.0) |
Contributor
There was a problem hiding this comment.
these are great. Can you also please add tests where the empty unit is the first unit where where the empty unit is the last unit? And also where there are multiple empty units in a row?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A request from @bendichter on #2146