rebase - #10
Merged
Merged
Conversation
fix(press-role): Ignore permissions for press members
(cherry picked from commit 2fb7dd8)
fix(press-role): Ignore permissions for press members (backport frappe#2939)
- Don't commit in test mode - Delete Incident Settings at setUp - Use patch instead of patch.object for Mock Twillio stuffs, After switching to IntegrationTestcase looks like patch.object not working perfectly - Mock sites_down property of incident as that requires a monitor server configured in press settings
- Recently, we added restriction that only team members can be added in press role, so refactored that - Add one test for validation of above clause
chore: Sync Changes from Master to Develop
…ting status Error Log - 7qbtbtbnia
chore: Sync Changes from Master to Develop
Also, added support for bulk polling
Mostly are broken due to recent changes in bench archival validation
In framework freeze_time doesn't work with Python 3.10 Add compatibility support for that
…st without deployment
Due to recent changes fw will raise error if you pass something like this frappe.get_doc(Bench, <Bench Object>) Always pass a string argument frappe.get_doc(Bench, bench-00003-xxxxxxx)
In Framework, it will raise error if you pass a object in get_doc method
chore: Add hetzner cloud provider filter
fix: Pass mandatory platform field to `create_image` Press Job
… cool off period (cherry picked from commit b97d698)
(cherry picked from commit ecf8d83)
(cherry picked from commit 57ead31) # Conflicts: # press/press/doctype/incident/incident.json
feat(investigator): Investigator additions (backport frappe#2986)
this is a temporary fix and should be resolved in agent level
Errors weren't being shown (red text) as the dialog was closing on failure. - Also throw new error for files bigger than 5 GiB
(cherry picked from commit a8b426f) # Conflicts: # press/press/doctype/proxy_server/proxy_server.json
The `validate_set_only_once` method breaks `ip` and `agent_password` fields since those fields are at times changed because of some circumstance. (cherry picked from commit 2c3169a)
fix: Using ro to avoid breaking `set_only_once` validation (backport frappe#2988)
(cherry picked from commit 26bc8bc)
feat(metrics): Investigate build failures (backport frappe#2995)
fix: Make private_ip field read_only (backport frappe#2989)
(cherry picked from commit 7d0450b)
(cherry picked from commit 0cf53b2)
fix: Populate vm specs, update_server and get cloud init (backport frappe#2997)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.