fix: pagination service, common imports, and build errors#178
Open
Jayrodri088 wants to merge 1 commit intoNexacore-Org:mainfrom
Open
fix: pagination service, common imports, and build errors#178Jayrodri088 wants to merge 1 commit intoNexacore-Org:mainfrom
Jayrodri088 wants to merge 1 commit intoNexacore-Org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes pagination for courses/lessons and resolves backend build errors (wrong imports, missing entity, and dependency/type issues).
Changes
Pagination
common/services/pagination.service.ts): Implement genericpaginate<T>(repository, options, findOptions?)using TypeORMfindAndCount, returning{ data, total, page, limit, totalPages }.common/dto/pagination.dto.ts): Add query DTO withpage(default 1, min 1) andlimit(default 10, min 1, max 100), using@Type(() => Number)and class-validator.PaginationService; registered inAppModule.GET /coursesnow accepts?page=&limit=and returns paginated payload viafindAllPaginated; removed duplicate commented GET handler; controller no longer injectsPaginationService(used in service).GET /lessonsandGET /lessons/course/:courseIdaccept?page=&limit=and return paginated results viafindAllPaginatedandfindAllByCoursePaginated.Build / codebase fixes
UserandUserRole(e.g.../../users/entities/user.entity),Lesson(e.g.../../lessons/entities/lesson.entityor./entities/lesson.entity), andUserService(../../users/users.service) in auth, common, courses, lessons, quizzes, and rewards.^2.0.2inpackage.jsonsoPartialTyperesolves and Update DTOs type-check.id,completed,user/userId,lesson/lessonId) soProgressServicecompiles and runs.QuestionTypeimport from../entities/question.entityinquiz-response.dto.ts.UserRole.ADMINinstead of'admin'in@Roles()for admin-only routes.Testing
npm run buildpasses (exit code 0).?page=1&limit=10and return paginated responses without runtime errors.Closes: #156