merging master into experiimental#351
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| npx hardhat run scripts/deploy.js --network optimism | ||
| # ... etc for each chain | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Documentation references non-existent script directory paths
High Severity
The deployment documentation instructs users to run commands like node scripts/deploy-evm-chain.js and cp scripts/hardhat.config.template.js hardhat.config.js, but these scripts are actually located at Scripts/Smart Contracts/, not scripts/. Every command users run following the documentation will fail with "file not found" errors. The deployment scripts exist but at the wrong path documented.
Additional Locations (2)
| npm run deploy:all:testnet | ||
| npm run deploy:aptos:testnet | ||
| npm run deploy:sui:mainnet | ||
| # ... see package.json for all scripts |
There was a problem hiding this comment.
Missing npm scripts referenced in documentation
High Severity
The documentation claims users can run npm scripts like npm run check-status, npm run deploy:ethereum:testnet, and npm run deploy:all:testnet, but the root package.json contains no scripts section at all—only a devDependency for mermaid-cli. Users attempting to run these documented commands will get "missing script" errors.
Additional Locations (1)
| 3. **Checklist**: `DEPLOYMENT_CHECKLIST.md` - Step-by-step checklist | ||
| 4. **Status**: `DEPLOYMENT_STATUS.md` - Current deployment status | ||
| 5. **Scripts**: `scripts/README.md` - Scripts documentation | ||
| 6. **Summary**: `scripts/DEPLOYMENT_AUTOMATION_SUMMARY.md` - Automation overview |
There was a problem hiding this comment.
Documentation index references non-existent files
Medium Severity
The documentation index references scripts/QUICK_START.md and scripts/README.md as available documentation files, but these files don't exist at the specified paths. Users looking for the Quick Start guide or Scripts documentation will encounter broken references.
Additional Locations (1)
| shell: pwsh | ||
| run: | | ||
| & "OASIS Omniverse/STARAPIClient/run_star_api_test_suite.ps1" -Configuration Release -KillStaleTestHosts $true | ||
|
|
There was a problem hiding this comment.
STARAPIClient tests likely fail on Ubuntu
High Severity
The new test-starapi-client job runs run_star_api_test_suite.ps1 on ubuntu-latest via pwsh, but related STARAPIClient scripts in the same area use Windows-only tooling/paths (e.g., C:\..., MSVC). If run_star_api_test_suite.ps1 has similar assumptions, the workflow will fail and block build-and-package via needs.
Additional Locations (1)
| STAR ODK/NextGenSoftware.OASIS.STAR.CLI/publish/linux-arm64/DNA/Default/OASIS_DNA.json | ||
| STAR ODK/NextGenSoftware.OASIS.STAR.CLI/publish/linux-arm64/DNA/CelestialBodyDNA.json | ||
| STAR ODK/NextGenSoftware.OASIS.STAR.CLI/publish/linux-arm64/Cosmos.CRTCompat.dll | ||
| STAR ODK/NextGenSoftware.OASIS.STAR.CLI/publish/installers/star-cli-3.4.0-win-x64.exe |
There was a problem hiding this comment.
Entire publish gitignore block duplicated from merge
Low Severity
The entire block of publish directory entries (lines 315–877) is exactly duplicated at lines 878–1440, adding ~560 redundant lines from what appears to be a merge artifact. Additionally, most entries under publish/ subdirectories are already covered by the existing publish/ pattern on line 139, making them doubly unnecessary. Only the publishwin-x64/ entries aren't covered by the existing pattern.
Additional Locations (1)
railway-app
Bot
temporarily deployed
to
invigorating-recreation / production
railway-app
Bot
temporarily deployed
to
invigorating-recreation / production
railway-app
Bot
temporarily deployed
to
invigorating-recreation / production
railway-app
Bot
temporarily deployed
to
invigorating-recreation / production
railway-app
Bot
temporarily deployed
to
invigorating-recreation / production
railway-app
Bot
temporarily deployed
to
invigorating-recreation / production
railway-app
Bot
temporarily deployed
to
invigorating-recreation / production
railway-app
Bot
temporarily deployed
to
invigorating-recreation / production
railway-app
Bot
temporarily deployed
to
invigorating-recreation / production
…issionManager, ParksController uses HolonManager, AvatarService/AztecOASIS/RadixOASIS/COSMIC TODO comments converted to notes
…oud/Pinata PackageProjectUrl
Add AztecOASISProviderSettings (ApiBaseUrl, ApiKey, BridgeContractAddress, OperatorAccountAlias, Network) to OASISDNA and StorageProviderSettings. AztecOASIS constructor now accepts bridgeContractAddress/operatorAccountAlias and passes them to AztecBridgeService; no longer reads AZTEC_* env vars.
- SEEDSOASIS.cs: remove spurious .Result unwrap on synchronous GenerateKeyPairWithWalletAddress call; it returns OASISResult<IKeyPairAndWallet> directly, not a Task - Dockerfile.web4: clone NextGenSoftware-Libraries into both /NextGenSoftware-Libraries (for OASIS2 projects using ../../../) and /holochain-client-csharp/NextGenSoftware-Libraries (for HoloNET projects using ../) so both path resolutions resolve correctly in the container
… and don't block WebAPI build
Replace placeholder with comprehensive v1.0.6 OASIS Omniverse Reboot release notes covering .NET 10 upgrade, ecosystem relaunch at oasisomniverse.one, WEB4-WEB10 tiers, FAHRN routing, HolonicBraid mesh config, and 30+ provider ecosystem tag set.
…elative refs resolve
… TryParse; add async to mission controller methods
…ore Web3 holon save
…ning for non-fatal holon save failures, add holon save success logging
…rialisation, web5 build fixes, Wizard MintedByAvatarId support
…atabase sub-properties before clearing repository refs
…ository race condition
- 9 tests in ONETControllerLifecycleTests: singleton caching, GetNetworkStatus, StartNetwork, StopNetwork, GetNetworkStats, GetNetworkTopology, null-body 400s, GetConnectedNodes without signature headers - 12 tests in ONODEControllerLifecycleTests: singleton caching, GetNodeStatus, GetNodeInfo, StartNode, StopNode (not running → 400), RestartNode, GetNodeMetrics, GetNodeLogs, GetConnectedPeers, GetNodeStats, GetNodeConfig, null-body 400s - Updated ONET-ONODE-SESSION-NOTES.md with Phase 5-7 entries and revised TODO list
… success is not masked by Solana send retries
…comments in Avalanche/Base/Cosmos/EOSIO ParkManager second constructor: base class handles all init, comment was vestigial. OAPPManager.PublishToDotNet: remove dead draft comments above working Process.Start call. Avalanche/Base/Cosmos/EOSIO GenerateKeyPair: replace misleading TODO with explanatory comment — provider-specific secp256k1 key generation already done via Nethereum above the KeyHelper call (which is used only as an IKeyPairAndWallet container).
- Add LeelaAI to AIProviderType enum - Add LeelaAISettings class and Web6Settings.LeelaAI property to OASISDNA - Add LeelaAI API key field to Web6ApiKeysSettings (env: LEELA_API_KEY) - Wire up key loading and Lambda endpoint in AIProviderManager - Suppress tool definitions for LeelaAI (API returns 400 if tools present) - Model fixed to "leela" per OpenAPI spec; endpoint appends /v1/chat/completions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 participant
Note
Medium Risk
Moderate risk because it changes CI orchestration by adding a new
test-starapi-clientjob and making release builds depend on it; failures or environment assumptions in the PowerShell test suite could block packaging. Other changes are documentation and.gitignorehygiene with minimal runtime impact.Overview
CI now runs the STARAPIClient automated suite by adding a new
test-starapi-clientjob that executesOASIS Omniverse/STARAPIClient/run_star_api_test_suite.ps1, uploadsTestResults/artifacts, and is required forbuild-and-package.Repo hygiene and docs were expanded:
.gitignorenow excludes common deployment secrets/config (e.g..env,hardhat.config.js,deployed-addresses.json,*.key/*.pem) and STAR CLI publish/install artifacts; a staleDockerfile.star-api.newwas removed; and multiple newDocs/Devs/*guides were added/linked covering smart-contract deployment and cross-platform getting-started/installer workflows.Written by Cursor Bugbot for commit d69b90f. This will update automatically on new commits. Configure here.