chore(format): apply biome to existing files#71
Closed
MeloMei wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR primarily applies consistent formatting and line-wrapping across tests, command registration, and orchestration/service code to improve readability and align with the project’s style conventions.
Changes:
- Reflowed long expressions (spies, expectations, UI payloads, and nested ternaries) into consistent multi-line formatting.
- Normalized array/object literal formatting in orchestration/services for clearer output construction.
- Minor import/export ordering adjustments.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/scout-targeting.test.ts | Reformats spies and expectations for consistent wrapping. |
| test/preset-orchestrator.test.ts | Reformats preset inputs and expectation blocks. |
| test/init-orchestrator.test.ts | Condenses chained mocks and reflows expectations. |
| test/doctor.test.ts | Reflows nested config construction in test cases. |
| test/agent-run.test.ts | Reflows a long toHaveBeenCalledWith assertion. |
| src/services/repository-targeting.ts | Wraps long throw message and expands return type formatting. |
| src/services/index.ts | Adjusts ordering within a re-export block. |
| src/services/content.ts | Reflows markdown line construction for groups/suggestions. |
| src/orchestration/preset.ts | Reflows UI payload construction and long conditional strings. |
| src/orchestration/init.ts | Reflows UI key/value entries and long expressions. |
| src/orchestration/analyze.ts | Reflows conditional assignments and candidate mapping for readability. |
| src/orchestration/agent.ts | Reflows long conditionals, UI copy, and argument lists. |
| src/infra/config.ts | Reflows Object.fromEntries mapping for readability. |
| src/commands/scout.ts | Condenses the action options type into a single line. |
| src/commands/preset.ts | Reflows command builder chaining and option handler formatting. |
| src/commands/index.ts | Reorders export list entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #68 as agreed in the PR thread. Runs
biome check --writeacross the 16 source files that had pre-existing format / organize-imports drift, bringing CI back to 0 errors.Background
After #68 was merged,
bunx biome ci --linter-enabled=false src test index.ts package.json tsconfig.jsonstill reported 18 errors onmain. None of these errors were introduced by #68 — they are pre-existing drift left over from the biome bump in #63 that never got a full reformat sweep. This PR closes that gap in one mechanical commit.Verification
$ bunx biome ci --linter-enabled=false src test index.ts package.json tsconfig.json
Checked 134 files in 169ms. No fixes applied.
(0 errors after this PR)
Changes
Pure mechanical output of
biome check --write. No logic changes. The diff is split across:src/...) — whitespace and import-order normalizationtest/...) — whitespace and import-order normalizationSpot-checked diffs:
src/commands/index.ts— single import reordered alphabeticallysrc/services/index.ts—typekeyword position reordered alphabeticallysrc/commands/scout.ts— multi-line type signature collapsed to one line under the 120 char widthNotes