Skip to content

chore(format): apply biome to existing files#71

Closed
MeloMei wants to merge 1 commit into
NianJiuZst:mainfrom
MeloMei:chore/biome-format-existing-files
Closed

chore(format): apply biome to existing files#71
MeloMei wants to merge 1 commit into
NianJiuZst:mainfrom
MeloMei:chore/biome-format-existing-files

Conversation

@MeloMei

@MeloMei MeloMei commented Jun 15, 2026

Copy link
Copy Markdown

Summary

Follow-up to #68 as agreed in the PR thread. Runs biome check --write across the 16 source files that had pre-existing format / organize-imports drift, bringing CI back to 0 errors.

Background

After #68 was merged, bunx biome ci --linter-enabled=false src test index.ts package.json tsconfig.json still reported 18 errors on main. None of these errors were introduced by #68 — they are pre-existing drift left over from the biome bump in #63 that never got a full reformat sweep. This PR closes that gap in one mechanical commit.

Verification

$ bunx biome ci --linter-enabled=false src test index.ts package.json tsconfig.json
Checked 134 files in 169ms. No fixes applied.
(0 errors after this PR)

Changes

Pure mechanical output of biome check --write. No logic changes. The diff is split across:

  • 10 source files (src/...) — whitespace and import-order normalization
  • 6 test files (test/...) — whitespace and import-order normalization

Spot-checked diffs:

  • src/commands/index.ts — single import reordered alphabetically
  • src/services/index.tstype keyword position reordered alphabetically
  • src/commands/scout.ts — multi-line type signature collapsed to one line under the 120 char width

Notes

  • Zero functional changes; safe to land independently
  • Recommend a clean rebase / no-squash so the format-only commit stays isolated and easy to revert if needed

Copilot AI review requested due to automatic review settings June 15, 2026 11:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR primarily applies consistent formatting and line-wrapping across tests, command registration, and orchestration/service code to improve readability and align with the project’s style conventions.

Changes:

  • Reflowed long expressions (spies, expectations, UI payloads, and nested ternaries) into consistent multi-line formatting.
  • Normalized array/object literal formatting in orchestration/services for clearer output construction.
  • Minor import/export ordering adjustments.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/scout-targeting.test.ts Reformats spies and expectations for consistent wrapping.
test/preset-orchestrator.test.ts Reformats preset inputs and expectation blocks.
test/init-orchestrator.test.ts Condenses chained mocks and reflows expectations.
test/doctor.test.ts Reflows nested config construction in test cases.
test/agent-run.test.ts Reflows a long toHaveBeenCalledWith assertion.
src/services/repository-targeting.ts Wraps long throw message and expands return type formatting.
src/services/index.ts Adjusts ordering within a re-export block.
src/services/content.ts Reflows markdown line construction for groups/suggestions.
src/orchestration/preset.ts Reflows UI payload construction and long conditional strings.
src/orchestration/init.ts Reflows UI key/value entries and long expressions.
src/orchestration/analyze.ts Reflows conditional assignments and candidate mapping for readability.
src/orchestration/agent.ts Reflows long conditionals, UI copy, and argument lists.
src/infra/config.ts Reflows Object.fromEntries mapping for readability.
src/commands/scout.ts Condenses the action options type into a single line.
src/commands/preset.ts Reflows command builder chaining and option handler formatting.
src/commands/index.ts Reorders export list entries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MeloMei MeloMei closed this Jun 15, 2026
@MeloMei MeloMei deleted the chore/biome-format-existing-files branch June 15, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants