Belated sync#264
Conversation
|
Not sure why some unit tests are failing on mergers I don’t remember editing. Maybe I touched something inadvertently. I’ll look into it. also, whoops! I didn’t realize I was bombarding you with failed workflow errors too. My bad. |
|
The remainder of the failing unit tests are from when the tests refer to files not included in the repo. I'll redirect those tests and add the files to the repo in the next couple days or so EDIT: Oh, I guess these actions only do the uk-content tests, and the tests I was talking about were for the ukmm crate. So I won't need to handle those, I guess |
|
Hey, are you still working on this? |
|
Yes. There are still issues to be fixed before bringing it all back to the main repo again. For now, check the releases of the repo this PR comes from for 0.16.0 |
GingerAvalanche
force-pushed
the
master
branch
from
fbdcdba to
1e55b3a
Compare
|
LINTER APPEASED. I am so, so sorry about all the literally hundreds of emails you suffered as a result of me taking so long to figure out how to use clippy in my IDE |
|
Whoops, those were for the other branch. But in the news on this branch, I dunno why it's not compiling. The Copilot comment in the other thread implied it was a winit issue, but this is the first time I've had this issue. It didn't happen 4 days ago on ae372a1 and there were no changes to anything Cargo-related since then, so I'm confused about the |
|
Maybe it's related to a sub-dependency of one of the crates? Have you tried doing another build since then? |
When converting submods, just diff against an empty file, seeing as we have no good interface for converting to ukmm's dependency system
Fix a rare issue where a mod might not be logged for inclusion if it doesn't edit the same language as the mods in the edit manifest
Deletes the output folder if it can be deleted and if the output folder or method has changed Then resets pending, to log that another deployment is needed
Wish I could just tell mod authors to stop breaking mods, but since DeleteRev is always -1 anyway...
Similar to da97f4d but for SARCs
Accounts for when a MainStatic made from the DLC file is applied to a base game MainField/Static.smubin
Make errors with multiple contexts display more than just the top-most error, so that people stop claiming they get the same error. This is similar to the change that generifies the top-most error message, but I like this one more because it actually gives some info
Need to solve references to objects Currently refers to all objects as their own Needs to use a list of elements and a map of children
There's like 5 commits worth of changes in here. Screw it. Uh... Appeased the linter Implemented diff and merge behavior for subtypes in case I ever figure out how to implement it for the overall AnimSeq type Implemented diff and merge behavior for AnimSeq type as just passing the bas file through to the end Implemented and hooked the traverser into the initial AnimSeq conversion Turned Element extensions into a map of extension type: Extension so that we don't try to diff different extension types Probably some other stuff, I don't know
Linter appeasement!
Use MissingAampKey for missing aamp keys (novel idea!) Specify Self type in invalid-parameter-type errors
Probably way overkill, but better than failure I guess
|
At long last... Thank you for all the work you put into this. |
6 participants
Let's bring all this back home