Skip to content

fix: lock persona review and backup restore targets#185

Merged
EterUltimate merged 1 commit into
mainfrom
codex/fix-persona-review-backup
Jun 8, 2026
Merged

fix: lock persona review and backup restore targets#185
EterUltimate merged 1 commit into
mainfrom
codex/fix-persona-review-backup

Conversation

@EterUltimate

Copy link
Copy Markdown
Collaborator

Summary

  • lock persona/style review status updates by row id with optional group id guards
  • fix style review approval passing group id as reviewer comment
  • restore legacy/default persona backups into the current real AstrBot persona instead of the missing default placeholder
  • add regression tests for single style approval targeting and default backup restore

Issue

Fixes #184

Validation

  • python -m pytest tests\unit\test_persona_review_service.py tests\unit\test_persona_backup_service.py tests\unit\test_sqlalchemy_db_manager_contract.py -q
  • python -m py_compile webui\services\persona_backup_service.py webui\services\persona_review_service.py services\database\facades\learning_facade.py services\database\sqlalchemy_database_manager.py
  • python -m ruff check services\database\facades\learning_facade.py services\database\sqlalchemy_database_manager.py webui\services\persona_backup_service.py webui\services\persona_review_service.py tests\unit\test_persona_backup_service.py tests\unit\test_persona_review_service.py
  • git diff --check

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @EterUltimate, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@EterUltimate EterUltimate merged commit 3c91370 into main Jun 8, 2026
4 checks passed
@EterUltimate EterUltimate deleted the codex/fix-persona-review-backup branch June 8, 2026 23:43
@EterUltimate EterUltimate mentioned this pull request Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 人格审查

1 participant