Add idleTimeout and placeholder props#27
Open
shekharkhedekar wants to merge 1 commit intoNightCafeStudio:mainfrom
Open
Add idleTimeout and placeholder props#27shekharkhedekar wants to merge 1 commit intoNightCafeStudio:mainfrom
shekharkhedekar wants to merge 1 commit intoNightCafeStudio:mainfrom
Conversation
Author
|
@GusRuss89 @daleperforce this has been useful in our project - we ended up using a quicker timeout (200) and a react component as the placeholder. LMK if this is something you'd be open to. |
Contributor
|
@shekharkhedekar Please explain why you need a new placeholder instead of using the placeholderElement? The timeout as a configurable seem ok to me. |
Author
@daleperforce Good question! We have a loading skeleton react component that we would like to put in, so our usage ends up looking like this: <RenderIfVisible
visibleOffset={2000}
idleTimeout={200}
stayRendered
placeholder={
<div className="container">
<LoadingSkeleton />
</div>
}
>
<MyRepeatingElement />
</RenderIfVisible>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following props for increased customization:
idleTimeoutAllows users to customize the delay timeout forwindow.requestIdleCallbackplaceholderAllows users to pass a JSX element as the placeholder for increased flexibility overplaceholderElement/placeholderClass