Fix: Parse qop parameter in Proxy-Authenticate header#14
Open
lexifdev wants to merge 1 commit intoNik-Hendricks:mainfrom
Open
Fix: Parse qop parameter in Proxy-Authenticate header#14lexifdev wants to merge 1 commit intoNik-Hendricks:mainfrom
lexifdev wants to merge 1 commit intoNik-Hendricks:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While integrating with Twilio, I encountered an issue during SIP registration.
The SIP server responded with a 407 Proxy Authentication Required message, including a
Proxy-Authenticateheader like the following:However, the client was sending a
Proxy-Authorizationheader where theqopvalue was set toundefined:As a result, Twilio returned an authentication failure:
Upon investigation, I found that in node.js-sip’s Parser.js, the
qopfield was missing from the parsing definition for theProxy-Authenticateheader.After updating the parsing logic to match that of
WWW-Authenticate(by including theqopparameter), the client started sending the correctProxy-Authenticateheader:With this fix, registration succeeded as expected: