You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cast scan clean for ERROR, syntax error, No such file, does not exist, FATAL, PANIC, Traceback, command not found
local docs-lint guard from .github/workflows/test.yml: docs-lint-guard-ok
Merge Gate
Draft PR only. Do not merge until CI is green, REV/samorev passes and is posted, README/GIF is manually reviewed, and human explicit approval is given.
#140 contains the same installer-path repair with a newer end-to-end recording, and adds the reliability work this branch lacks: installer discovery through ash_sql_chain.py, a setup-readiness handshake, bounded failure diagnostics, positive and negative Docker smoke gates, shell hardening, and workload signal/exit-status preservation. Its corrected head passed all hosted checks and the refreshed artifacts were inspected at original resolution.
The branches diverged from the same base and both replace demos/ash_demo.cast and the binary demos/ash_demo.gif while editing the demo entrypoint and recorder. A trial merge produces text conflicts and a binary GIF conflict. This PR also edits frozen sql/ash-install.sql; its docs-lint check fails on that release-freeze guard.
The valuable README-only idea here should not be lost. After #140 lands, a focused follow-up can embed #140’s reviewed demos/ash_demo.gif and update the demo wording without regenerating assets or touching sql/. The optional pg_cron explanation and remaining sentence-case headings can be evaluated as separate README-only edits.
Superseded by #140. Thank you for the recording and visual-review groundwork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sql/ash-install.sqlinstead of the removeddevel/sql/ash-install.sqlManual Review Notes
The regenerated GIF is a real recording against a live Postgres 18 demo container. It shows:
ash.status()withversion=2.0-beta1, sampling enabled, and pg_cron availableash.periods()AAS triageash.chart(...)ash.top('wait_event', ...)ash.top('query_id', wait_event => 'Lock:tuple', ...)ash.top('wait_event', query_id => :top_qid, ...)Generated asset:
demos/ash_demo.gif: 1020x462, 843 frames, 380Kdemos/ash_demo.cast: 52KValidation
make -C demos recordcompleted successfullygifsicle --unoptimize --explode demos/ash_demo.gifproduced 843 full-size framesgit diff --checkbash -n demos/record.sh demos/container-entrypoint.sh demos/workload.shERROR,syntax error,No such file,does not exist,FATAL,PANIC,Traceback,command not found.github/workflows/test.yml:docs-lint-guard-okMerge Gate
Draft PR only. Do not merge until CI is green, REV/samorev passes and is posted, README/GIF is manually reviewed, and human explicit approval is given.