fix: avoid stale rollup reads - #123
Closed
NikolayS wants to merge 2 commits into
Closed
Conversation
This was referenced Jul 27, 2026
Open
Owner
Author
|
Superseded by #199, which keeps stale wide rollup reads honest without losing the healthy rounded-up dashboard fast path and landed on current main as 9efad9c. Closing this earlier attempt in favor of that successor; issue #122 remains open for the explicitly unclaimed older-than-physical-raw completeness case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
rollup_1mstops after its first minuteash._pick_source_agg()require the rollup watermark to reachuntilwhen raw coverssinceWhy
The 2.0 aggregate readers selected
rollup_1mfrom its retention start alone. If the rollup worker lagged or stopped, the readers returned plausible but incomplete values and omitted newer raw load.This is a release-candidate SQL correction on a
release/*branch because the beta installer is already stamped undersql/.Impact
The correction applies to the new aggregate surface that delegates to
_pick_source_agg():aas,timeline,periods, non-tietop, andchart.Validation
54362ff:stale rollup must fall back to raw, got rollup_1m6123780: exact source, covered-minute, and backend-second assertions passON_ERROR_STOP=1passgit diff --check main...HEADpassesCloses #122