fix: require DBLab for database-backed previews - #149
Draft
NikolayS wants to merge 6 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
env createbefore any remote mutationdbBackend = "none"as no-database exemptionsRoot cause
The platform treated
previewDbBackend = "none"and"template"as valid operator overrides even for applications that carry a database. A directenv create --db none|templaterequest could also bypass the app's intended DBLab policy. That made isolation depend on each manifest and caller being perfectly configured, allowing a database-backed preview to start without a DBLab clone and potentially inherit production-facing connection configuration.This change centralizes the classification and fails before state, DNS, SSH, or host mutation whenever a database-backed app resolves to anything except
dblab.Static apps (
kind = "static") and explicit no-database node apps (dbBackend = "none"with no database signals) resolve tononeand do not allocate DBLab.Validation
bun testThe branch only contains the policy implementation and corresponding test updates. It does not change or deploy the live control-plane trigger.