fix: guard AppStore state stamps with CAS - #156
Draft
NikolayS wants to merge 4 commits into
Draft
Conversation
Collaborator
samorev Code Review Report
BLOCKING ISSUES (1)HIGH
Summary
Note:
Review metadatasamorev-assisted review (AI analysis by Tanya301/samorev) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AppStorecompareAndSwap(expected, replacement)Why
Deploy and trigger work can spend time in CI and remote execution after reading an
AppRecord. Their final unconditionalupsertcould overwrite a newer SHA, release cursor, or configuration update made by another local samohost process. The new CAS stamp fails closed when the persisted record no longer matches the snapshot.The filesystem lock is held only for the short local read/check/atomic-write section, not across network or SSH work. Existing atomic
.tmp/fsync/rename persistence remains the write mechanism.Scope
This is the standalone state-safety prerequisite only. It contains no Caddy or project-routing script changes and is not bundled into #153. A later routing slice can use the same whole-record CAS when stamping its routing fingerprint.
Validation
bun test test/app-store-cas.test.ts test/app-command.test.ts test/trigger.test.ts— 92 passbun test— 1864 passbunx tsc --noEmit— passgit diff --check— pass