Improve integration test and LLM smoke test guidance in build-mcpb#59
Merged
JoeCardoso13 merged 2 commits intomainfrom Mar 25, 2026
Merged
Improve integration test and LLM smoke test guidance in build-mcpb#59JoeCardoso13 merged 2 commits intomainfrom
JoeCardoso13 merged 2 commits intomainfrom
Conversation
…TTERNS - Phase 3: split Verify section into three subsections (unit, integration, LLM smoke tests) each with command-first structure - Phase 3: replace 'not blocking' language with concrete write-then-run instructions; escape hatch is user's decision, not the agent's - Phase 3: document .env-based key setup and chained/tier-gated method patterns - Phase 3: gate now requires integration tests to be written with real assertions, not stubs or TODOs - PATTERNS.md: replace abstract placeholder templates with three concrete patterns (read-only, write-with-cleanup, tier-gated) derived from real playground repo experience - PATTERNS.md: add key rules covering cleanup, timestamped names, print for visibility, and one-test-per-method guidance
- PATTERNS.md: replace placeholder LLM test template with call_llm() helper pattern and concrete test examples - PATTERNS.md: add "concrete identifiers for required parameters" rule with examples (workspace GIDs, coordinates, unambiguous dates) - Phase 3: add "How to write" and "How to run" subsections for LLM smoke tests, matching the structure used for integration tests - Phase 3: gate now requires LLM smoke tests to be written with real assertions and to pass when ANTHROPIC_API_KEY is available
mgoldsborough
approved these changes
Mar 25, 2026
mgoldsborough
approved these changes
Mar 25, 2026
JoeCardoso13
added a commit
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client.premium_method(),"Your test prompt here") with derivation rules and real patterns (read-only, write-with-cleanup, tier-gated,call_llm()helper).env-based key setup, chained methods, concrete-identifiers rule for LLM promptsModel repos used as reference
Repos where these patterns were validated
Integration tests and LLM smoke tests were added to all 6 repos, exercising the patterns documented in this PR:
Key findings from validation
_request()crashed on 204 No Content responses because it unconditionally calledresponse.json()anthropicis missing from the template's dev dependencies: every repo hitModuleNotFoundError— tracked in Fix: load .env in integration test conftest mcp-server-template-python#8load_dotenv()is missing from the template's conftest: tracked in Add python-dotenv to scaffolded conftest.py for integration tests mcp-server-template-python#7Test plan
./scripts/validate.shpasses