Move integration/LLM tests from Phase 3 to Phase 5#61
Merged
JoeCardoso13 merged 4 commits intomainfrom Mar 27, 2026
Merged
Conversation
mgoldsborough
requested changes
Mar 25, 2026
Phase 3 verify previously gated on make test-integration and make test-llm. These require API keys, may involve complex auth, and fail ~75-80% of the time on first attempt — too much friction before the server is fully assembled. Phase 3 now gates on make check only (format, lint, typecheck, unit tests). Integration and LLM smoke tests move to a new Phase 5f step, run after the skill resource is wired and tools are finalized, with explicit guidance for working through failures and a non-blocking escape hatch.
JoeCardoso13
force-pushed
the
fix/skill-md-test-and-integration-gating
branch
from
7a6c79a to
923ddf4
Compare
mgoldsborough
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make test-integrationandmake test-llmfrom Phase 3 verify — Phase 3 now gates onmake checkonly (format, lint, typecheck, unit tests)Closes #43
Test plan
./scripts/validate.shpasses