Fix update-awareness QA issues (#52-#57)#61
Merged
shwetank-dev merged 7 commits intomainfrom Mar 19, 2026
Merged
Conversation
…eck failure If the background update check promise rejects before the 3-second timeout, the unhandled exception skips process.exit and the CLI hangs indefinitely. Closes #52 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Concurrent downloads in the same millisecond would write to the same temp path. Append a random suffix to ensure uniqueness. Closes #53 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The empty catch silently skipped bundles deleted from the registry, giving users no way to discover stale/orphaned cache entries. Closes #54 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Outdated bundles were updated sequentially. Since each download is independent, Promise.allSettled allows them to run concurrently. Closes #55 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
String equality fails if registry returns 'v1.0.0' vs '1.0.0'. Add isSemverEqual helper that strips the 'v' prefix before comparing, and use it in all three version comparison sites. Closes #56 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Exercises the full happy path against the live registry: cache a bundle, downgrade its version metadata, verify outdated detects it, run update, and confirm it is no longer outdated. Closes #57 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…on-zero exit on all-fail - Silence catch block in async exit handler (update check is best-effort) - Use crypto.randomUUID() instead of Math.random() for temp file suffix - Exit non-zero when all bundle updates fail so scripted pipelines don't proceed
mgoldsborough
approved these changes
Mar 18, 2026
Contributor
mgoldsborough
left a comment
mgoldsborough
left a comment
There was a problem hiding this comment.
made some qa fixes (minor). approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all six QA findings from the
issue-37-cli-add-bundle-update-awarenessreview:mpak outdated, instead of silently skipping itPromise.allSettledfor parallel downloads inmpak update(no args) instead of sequentialfor...ofisSemverEqualhelper for version comparisons across all three call sitesTest plan
@nimblebraininc/echo)mpak outdateddetects it →mpak updatefixes it →mpak outdatedreports all up to dateCloses #52, closes #53, closes #54, closes #55, closes #56, closes #57
🤖 Generated with Claude Code