Add ${mpak.*} runtime variable substitution in mcp_config.env#68
Open
mgoldsborough wants to merge 3 commits intomainfrom
Open
Add ${mpak.*} runtime variable substitution in mcp_config.env#68mgoldsborough wants to merge 3 commits intomainfrom
mgoldsborough wants to merge 3 commits intomainfrom
Conversation
When running an Upjack app (manifest has _meta["ai.nimblebrain/upjack"]), set UPJACK_ROOT to MPAK_WORKSPACE so entity data persists outside the ephemeral bundle cache. Non-Upjack bundles are unaffected.
…stitution
Bundles can now reference mpak runtime values (workspace, cache_dir,
bundle_name) in mcp_config.env via ${mpak.*} placeholders. This keeps
mpak framework-agnostic — the Upjack bundle declares its own env needs
in its manifest instead of mpak knowing about Upjack.
mgoldsborough
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp_config.envvia${mpak.*}placeholders:workspace,cache_dir,bundle_nameMPAK_WORKSPACEbefore env substitution so it's available to bundlesExample manifest usage:
{ "mcp_config": { "env": { "UPJACK_ROOT": "${mpak.workspace}", "MY_STATE": "${mpak.cache_dir}/state" } } }Test plan
${mpak.workspace}inmcp_config.env— verify it resolves correctlypnpm typecheck && pnpm lint && pnpm testall pass (141 tests, 0 failures)