chore(home): remove dead plain-JS home resources#379
Merged
Conversation
The inline home-dashboard and home-briefing-inline scripts (ui://nb/home-dashboard, ui://nb/home-briefing-inline) are the pre-React home UI. The live home is the React SPA at ui://home/dashboard (src/bundles/home/ui, served via platform/home.ts with a sidebar placement), which fetches and renders the briefing itself with the correct BriefingOutput schema. Both old resources are registered in buildCoreResourceMap() but referenced by nothing — no placement, no tool resourceUri binding, no client reads either URI anywhere in src/ or web/. home-dashboard.ts has been untouched since v0.1.0. Both also carried the same schema drift (stale category names, item.sentiment instead of item.type), so they rendered zero sections against real briefing data. Rather than fix a dead render path (the original intent of this branch), delete it: both scripts, their styles, their registry entries, and the inline test. Removing a broken, schema-drifted, unreferenced renderer beats hardening it. Supersedes the inline-renderer fix this branch originally carried.
mgoldsborough
force-pushed
the
fix/inline-briefing-categories
branch
from
e736b41 to
41ac982
Compare
mgoldsborough
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed (and why this PR pivoted)
This branch originally fixed the schema drift in the inline home-briefing renderer. QA review flagged that a sibling resource (
home-dashboard.ts) had the identical defect, unfixed — "fix everywhere or collapse to one path."Tracing it down, the real finding is bigger: both inline resources are dead code.
home-dashboard.ts(ui://nb/home-dashboard) andhome-briefing-inline.ts(ui://nb/home-briefing-inline) are the pre-React home UI.ui://home/dashboard(src/bundles/home/ui, served viaplatform/home.tswith a sidebar placement, priority 0). It fetchesbriefingon thenbsource and renders it itself with the correctBriefingOutputschema.buildCoreResourceMap()but referenced by nothing — no placement, no toolresourceUribinding, and no client reads either URI anywhere insrc/orweb/.home-dashboard.tshasn't been touched since v0.1.0.needs_attention/coming_upcategories,item.sentimentinstead ofitem.type), so they rendered zero sections against real briefing data.So rather than harden a dead, schema-drifted render path, delete it: both scripts, their styles, their registry entries in
index.ts, and the now-orphaned inline test.Diff
Pure removal — 406 lines across 5 files:
scripts/home-dashboard.ts,scripts/home-briefing-inline.ts(deleted)styles.ts—HOME_DASHBOARD_STYLES,HOME_BRIEFING_INLINE_STYLESremovedindex.ts— both imports +resourcesmap entries removedtest/unit/core-resources/home-briefing-inline.test.ts(deleted)bun run verify:staticpasses; remaining core-resources tests pass. No references to the removed exports remain.Resolves QA review
QA offered two outcomes — fix both, or (if dead) delete. This is the delete branch: a registered resource carrying a known-broken render path is pure carrying cost.