Documentation fixes - #424
Merged
Merged
Conversation
Its registry-listing step failed the v0.41.0 release, and Zed publishing is no longer wanted in the release path. Removed rather than disabled. Scoped to the release workflow only: the basilisk-zed tree and its CI job are untouched.
v0.41.0 published three of five VSIX targets to Open VSX, took a 503 on the fourth, and 'set -e' aborted the loop — leaving win32-arm64 and win32-x64 unpublished with no retry and no second chance. Both publish loops (Open VSX and Marketplace) now: - retry each target up to 4 times with exponential backoff, - treat 'already exists' as the desired end state, so a re-run or a partial retry no longer fails on targets that already landed, - attempt every target before failing, so one bad target cannot strand the ones behind it, - still fail the job if any target ends up unpublished — a partial push is never reported as green. The Marketplace loop additionally exits immediately on an expired PAT with the steps to mint a new one, since retrying that can only fail. Verified with a stub publisher across four paths: all-success, all- already-published, transient-then-success, and permanent-failure. The permanent-failure case attempts both targets and reports both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Removes the claim that Basilisk's conformance submission was procedurally clean from every document that repeated it, and fixes the release pipeline so a dead gate, a removed channel, and a transient registry error can no longer stop a release from shipping.
What Was Changed or Deleted?
1. The "we followed the process correctly" claim is deleted (18 files)
The retraction material asserted that nobody set out to game the suite, that nothing was concealed from
python/typing, and that the harness ran unmodified with default configuration and every rule enabled. In documents whose purpose is to record a failure, that reads as a defence of conduct. It was repeated across every README, both locales of the site, both blog posts, and the integrity audit.Deleted, in all its variants:
python/typing: the submission ran the suite's own unmodified harness, with default configuration and every rule enabled" — plus the integrity audit's longer form, "no special-casing of the harness, no doctored output, no disabled rules, no edited results file"Kept deliberately — the admissions, which are the point of these documents: "This was a mistake and a failure to verify", "we were wrong because we did not verify it", the account of how the score became the target, and the link to the author's apology in every location.
Authored files edited: docs/readme/README.src.md, docs/readme/README.zh.src.md, the four hand-written nvim/Zed READMEs, docs/CONFORMANCE-INTEGRITY-AUDIT.md, both conformance docs, both
index.njkheroes, and both blog posts.README.md,README.zh.md,README-pypi.mdand the twovscode-extensionREADMEs are generated and were regenerated fromdocs/readme/.2. Release pipeline unblocked
publish-zedjob (93 lines) is deleted from release.yml. Its registry-listing step failed the v0.41.0 release. Scoped to the release workflow only; thebasilisk-zedtree and its CI job are untouched, and the mirror is already current at v0.41.0.set -eaborted the loop — leavingwin32-arm64andwin32-x64unpublished with no retry. Both publish loops (Open VSX and Marketplace) now retry each target up to 4 times with exponential backoff, treatalready existsas the desired end state so re-runs and partial retries are safe, and attempt every target before failing so one bad target cannot strand the ones behind it. The job still fails if any target ends up unpublished — a partial push is never reported as green. The Marketplace loop additionally exits immediately on an expired PAT with the steps to mint a new one, since retrying that can only fail.How Do The Automated Tests Prove It Works?
No test suite covers workflow YAML or marketing prose, so this was verified directly:
published=2), all-already-published (skipped=2), transient-then-success — the exact v0.41.0 failure, which now retries through two 503s and succeeds — and permanent-failure, which reportsfailed=2, proving both targets are attempted rather than the second being stranded.release.ymlparses; 12 jobs,publish-zedabsent, no danglingneeds. Both publish steps'run:blocks passbash -n.python3 scripts/gen_conformance_reference.py --check→ "READMEs are in sync with docs/readme/", so the generated copies cannot drift from the sources.not an attempt to game,Nobody set out,nothing was concealed,有意操纵,没有人试图,get away with something,蒙混过关) returns zero matches.make ciwas not run: this is a docs-and-workflow change carrying nothing the Rust matrix exercises, and the PR is labelleddocs-onlyaccordingly.Spec / Doc Changes
Everything here is documentation, site content, or CI workflow YAML. No spec IDs added or renamed; no checker rule, crate, or diagnostic behaviour is touched.
Breaking Changes
Zed users who installed from the registry keep the extension; it simply stops receiving version bumps.
Refs #379